Skip to content

RF: Replace pickle with cloudpickle for input/output specs #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2019

Conversation

effigies
Copy link
Contributor

@effigies effigies commented Jul 29, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

Replace pickle with cloudpickle for input/output specs.

As noted in #96 (comment), the problem with cloudpickling specs should have been resolved by cloudpipe/cloudpickle#245. This hit version 0.8.0, so I'm updating the minimum required version, as well.

Checklist

  • All tests passing
  • I have added tests to cover my changes
  • I have updated documentation (if necessary)
  • My code follows the code style of this project
    (we are using black: you can pip install pre-commit,
    run pre-commit install in the pydra directory
    and black will be run automatically with each commit)

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #104 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #104      +/-   ##
=========================================
- Coverage    86.5%   86.5%   -0.01%     
=========================================
  Files          14      14              
  Lines        2179    2178       -1     
  Branches      545     545              
=========================================
- Hits         1885    1884       -1     
  Misses        205     205              
  Partials       89      89
Flag Coverage Δ
#unittests 86.5% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pydra/engine/core.py 87.39% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59083f...06b2d35. Read the comment docs.

@satra satra merged commit 69ab220 into nipype:master Jul 29, 2019
@effigies effigies deleted the fix/cloudpickle_specs branch July 29, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants