fix(dev): limit /_vfs to local ips only
#3154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nitro dev server has a default
/_vfsendpoint for debugging virtual templates, however, it can leak some limited information when usingnitro dev --host.This PR limits this feature to only when incoming request IP is strictly
::1or127.*.Note
this change, limits some valid cases too, like using external IP of same computer to access the endpoint, but considering it is just a debugging feature I think worth doing it and minimizing exposure changes.
Alternative option was validating incoming host but it can be also forged.
/cc @danielroe @antfu