Expose and document SlideIndicator contract #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DDavidPrime, Thank you for the PR. Can you please add the usage process to the documentation too? Thanks & regards, |
|
Of course! I'm a bit busy, but will try to have it done in the following day or two. 🫡 |
|
Okay, then I will merge the PR and I am also planning to release the next update after some bug fixes, so please try to do it ASAP. Thanks. |
|
@nixrajput All done! Please review it and let me know if there's something else to fix/update/add. 🙌🏼 |
|
@DDavidPrime thank you for the contribution to the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue mentioned in #35
Besides exposing the
SlideIndicator, I've added documentation for it as well, since it may come useful to people who would like to make their own implementations of the slide indicators.