Update and extend the protocol/packet tests #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add in a new way of testing with the addtion of closure driven tests
and skip options. Expand tests to cover all of the common cases for all
supported protocol levels. Added in the msgpack encode/decode for SIO
version 2 handling. The current package test coverage is:
ok github.com/njones/socketio/protocol 0.008s coverage: 80.6% of statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in a new way of testing with the addition of closure driven tests
and skip options. Expand tests to cover all of the common cases for all
supported protocol levels. Added in the msgpack encode/decode for SIO
version 2 handling. The current package test coverage is:
Fixes #4
[ look to the wiki for more info on the new test format ]