Update crypto.createCipher() to crypto.createCipheriv() #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses warning nodejs/node#16746
|
@danielsharvey Thanks for providing this! Currently however it doesn't support the CCM or GCM AES cipher modes. A new branch is in progress to address this as well as a couple of other issues such as the incorrect encrypt then MAC, lack of a key derivation to strengthen the supplied key helping protect the at rest data and of course the need to move away from the legacy |
|
Thanks @jas-, I hadn't realised this was in progress (see https://github.com/jas-/connect-mysql-fork/commit/d6581b2980de068c0e0e7ca4d91f0b2def8ac49c). |
|
@danielsharvey Thanks for providing this and the second set of eyes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses warning nodejs/node#16746 (closes #42)