Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote on prefix-only core modules #1206

Merged
merged 20 commits into from
Apr 14, 2022
Merged

Vote on prefix-only core modules #1206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
35a43f0
Vote on `node:`-only core modules
aduh95 Apr 6, 2022
4a22bdb
vote from aduh95
aduh95 Apr 6, 2022
cf70874
vote from cjihrig
cjihrig Apr 6, 2022
c03f164
vote from mhdawson
mhdawson Apr 6, 2022
82cabaa
vote from apapirovski
apapirovski Apr 6, 2022
e14b802
vote from Rich Trott
Trott Apr 7, 2022
e9b7b5b
vote from fhinkel
fhinkel Apr 7, 2022
20ab018
vote from RaisinTen
RaisinTen Apr 7, 2022
aaae162
vote from targos
targos Apr 7, 2022
c4cce1c
vote from gireeshpunathil
gireeshpunathil Apr 7, 2022
2b8a651
vote from Matteo Collina
mcollina Apr 7, 2022
26d6a01
vote from Richard Lau
richardlau Apr 7, 2022
49198b5
vote from Beth Griggs
BethGriggs Apr 7, 2022
e0a66c4
vote from gireeshpunathil
gireeshpunathil Apr 7, 2022
ac8ad52
vote from Danielle Adams
danielleadams Apr 10, 2022
c4b2b45
Vote for test runner node prefix
jasnell Apr 10, 2022
6a8f976
vote from MylesBorins
MylesBorins Apr 10, 2022
990e77d
close vote and aggregate results
aduh95 Apr 11, 2022
93e32e0
add vote from joyeecheung
aduh95 Apr 12, 2022
ea4fddc
close vote and aggregate results
aduh95 Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
155 changes: 155 additions & 0 deletions votes/2022-04-11-0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,155 @@
{
"description": "`node:`-only core modules and built-in test runner module",
"outcome": {
"winner(s)": [
"Ship the test runner as `node:test` and `require('test')` loads from userland."
]
},
"votes": {
"joyeecheung": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 2,
"Ship the test runner as `node:test` and `require('test')` throws.": 1,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
},
"MylesBorins": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 0,
"Ship the test runner as `node:test` and `require('test')` throws.": 0,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
},
"danielleadams": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": -1,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 0,
"Ship the test runner as `node:test` and `require('test')` throws.": 2,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 2,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 3
},
"gireeshpunathil": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 1,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 0,
"Ship the test runner as `node:test` and `require('test')` throws.": 0,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
},
"jasnell": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 1,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": -1,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": -1,
"Ship the test runner as `node:test` and `require('test')` throws.": 0,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 1,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": -1,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
},
"mcollina": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": -100,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": -90,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 100,
"Ship the test runner as `node:test` and `require('test')` throws.": -80,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": -10,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": -10
},
"BethGriggs": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 4,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 5,
"Ship the test runner as `node:test` and `require('test')` throws.": 3,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 1,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
},
"richardlau": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": -1,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 1,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 5,
"Ship the test runner as `node:test` and `require('test')` throws.": 5,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 10,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 4,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 7
},
"fhinkel": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 0,
"Ship the test runner as `node:test` and `require('test')` throws.": 0,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
},
"targos": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 3,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 1,
"Ship the test runner as `node:test` and `require('test')` throws.": 2,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 3,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 1
},
"RaisinTen": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 6,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 4,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 7,
"Ship the test runner as `node:test` and `require('test')` throws.": 3,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 5,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 2,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 1
},
"Trott": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 1,
"Ship the test runner as `node:test` and `require('test')` throws.": 0,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 1,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 1,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 1
},
"apapirovski": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 1,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 5,
"Ship the test runner as `node:test` and `require('test')` throws.": 3,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 2,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 6,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 4
},
"cjihrig": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": -100000,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": -5,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 1,
"Ship the test runner as `node:test` and `require('test')` throws.": -1,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 1000000,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": -50,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": -100
},
"mhdawson": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 1,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 2,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 7,
"Ship the test runner as `node:test` and `require('test')` throws.": 5,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 3,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 6,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 4
},
"aduh95": {
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 0,
"Ship the test runner as `node:test` and `require('test')` throws.": 0,
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
}
},
"refs": ["https://github.com/nodejs/TSC/pull/1206"]
}
25 changes: 25 additions & 0 deletions votes/2022-04-11-1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"description": "Ship the test runner as node:test and require('test') loads from userland.",
"refs": ["https://github.com/nodejs/TSC/pull/1206#issuecomment-1096855085"],
"outcome": "Yes",
"votes": {
"aduh95": 1,
"richardlau": 1,
"RaisinTen": 1,
"apapirovski": 1,
"mhdawson": 1,
"BethGriggs": 1,
"joyeecheung": 1,
"mcollina": 1,
"ChALkeR": 1,
"cjihrig": -1,
"jasnell": -1,
"Trott": 0,
"targos": 0,
"gireeshpunathil": 0,
"fhinkel": 0,
"tniessen": 0,
"BridgeAR": 0,
"MylesBorins": 0
}
}