This repository was archived by the owner on Feb 17, 2019. It is now read-only.
fix sample to use Call #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this example we should be using Call not MakeCallback. Update to be consistent with the napi example
|
@NickNaso can you take a look and review? |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@NickNaso I think the changes you suggest make sense, but I think it would be good to make then to all of the examples together as opposed to making the change in this PR. I'll go ahead and land this one and then you can open a PR for the other changes. |
mhdawson
added a commit
that referenced
this pull request
Jul 4, 2018
In this example we should be using Call not MakeCallback. Update to be consistent with the napi example PR-URL: #30 Reviewed-By: NickNaso <[email protected]>
|
Landed as 75ee5e5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this example we should be using Call not
MakeCallback. Update to be consistent with the
napi example