Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that externals are frozen objects #306

Closed
gabrielschulhof opened this issue Apr 28, 2018 · 1 comment
Closed

Document that externals are frozen objects #306

gabrielschulhof opened this issue Apr 28, 2018 · 1 comment
Assignees
@gabrielschulhof

Comments

@gabrielschulhof
Copy link
Collaborator

Re: nodejs/node#14256
@gabrielschulhof gabrielschulhof self-assigned this Apr 30, 2018
@gabrielschulhof gabrielschulhof mentioned this issue Apr 30, 2018
Closed
3 tasks
@gabrielschulhof
Copy link
Collaborator Author

Fixed in d3255cad8e2a6ba03629903743e166401fc3597e.

MylesBorins pushed a commit to nodejs/node that referenced this issue May 4, 2018
@MylesBorins
n-api: document the look of napi_external values
1908668 
Describe what JavaScript values of type `napi_external` look like in
JavaScript.

Fixes: nodejs/abi-stable-node#306
PR-URL: #20426
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this issue May 5, 2024
n-api: document the look of napi_external values
bb65a0c 
Describe what JavaScript values of type `napi_external` look like in
JavaScript.

Fixes: nodejs/abi-stable-node#306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrielschulhof gabrielschulhof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

n-api: document the look of napi_external values gabrielschulhof/node
1 participant
@gabrielschulhof