Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move gyp-next to the nodejs org #475

Closed
ryzokuken opened this issue Mar 9, 2020 · 28 comments
Closed

Move gyp-next to the nodejs org #475

ryzokuken opened this issue Mar 9, 2020 · 28 comments

Comments

@ryzokuken
Copy link
Contributor

Request to move gyp-next (https://github.com/ryzokuken/gyp-next) to the nodejs organization. More context at nodejs/node#32090.

@ryzokuken
Copy link
Contributor Author

/cc @targos @cclauss @rvagg @MylesBorins

@targos
Copy link
Member

targos commented Mar 9, 2020

+1

1 similar comment
@mhdawson
Copy link
Member

mhdawson commented Mar 9, 2020

+1

@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 9, 2020 via email

@joyeecheung
Copy link
Member

+1

@rvagg
Copy link
Member

rvagg commented Mar 10, 2020

Full context:

GYP is a Google tool, now deprecated by them, we've taken over maintenance of it and it's used in nodejs/node and node-gyp (libuv too, but they're using a pruned-down version and are about to rip it out entirely). We're in the middle of a synchronization effort between the two projects and the repo on question here should be a synthesis of all that so ought to end up as the source of truth for both nodejs/node and nodejs/node-gyp.

We can't just take over the name "GYP" due to copyright concerns. Refael put in a bunch of work to make GYP3 but that stalled in a previous attempt to bring it into the org. The name "GYP3" is also too similar to "GYP". In private discussions (Myles also involved in these on behalf of Google), "gyp-next" was arrived at as the best attempt at a name that was distinct enough from "GYP" that it indicated it was a separate project. Nobody's particularly enamored with the name, it's a pragmatic choice.

If someone has a better name, now would be the time to speak up, otherwise I suspect "gyp-next" is going to be baked in for good.

@Qard
Copy link
Member

Qard commented Mar 10, 2020

PYG: (Here's the) Project You Generated 😆

@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 10, 2020 via email

@cclauss
Copy link

cclauss commented Mar 10, 2020

pip install pyg does have a ring to it. But it is already taken by @rubik‘s long defunct https://pypi.org/project/pyg/

@Qard
Copy link
Member

Qard commented Mar 10, 2020

Hasn't been updated in seven years. Maybe we could ask to reclaim the name? 🤔

Alternatively:

JUNA - Just Use Ninja Already 😉
JHEF: Javacript Has Enough Frameworks (so we made one for Python instead)
NACL: Node.js Abstract Compiler Launcher (That'll get us away from Google copyright concerns for sure :trollface: )

More seriously:

NUB - Node.js Universal Builder
JUBE - JSON-based Universal Build Environment

@richardlau
Copy link
Member

I kind of feel that, boring as it may be, anything that doesn't have "gyp" as part of its name is just going to be confusing.

@Trott
Copy link
Member

Trott commented Mar 10, 2020

I very much like pyg. Can't get the Beatles song "Little Pygies" out of my head now.

That'll do: pyg. That'll do.

Er, uh, more seriously, I kinda agree with @richardlau that including gyp as part of the name is the user-friendly thing to do.

@sam-github
Copy link
Contributor

I agree, to, should have gyp. I'm fine with gyp-next, the README should be clear that the goal is not to resuscitate gyp or encourage its use for new projects, but to maintain it sufficiently for Node.js addons and libuv.

@cclauss
Copy link

cclauss commented Mar 10, 2020

I would advocate that this module can be pip install-ed from PyPI. My sense is that there has been a lot of unnecessary questions and delay in working with the current gyp because we have resisted the use of pip install.

@sam-github
Copy link
Contributor

Can we pip install and vendor it? Node.js build doesn't depend on pip ATM for building, but if pip's a better way to get it into our deps or tools than cp -r, I'm OK with using it.

@cclauss
Copy link

cclauss commented Mar 10, 2020

Yes. pip and vendor can co-exist.

@targos
Copy link
Member

targos commented Mar 10, 2020

@bnb
Copy link
Contributor

bnb commented Mar 10, 2020

SGTM :shipit:

@ryzokuken
Copy link
Contributor Author

Can we pip install and vendor it?

Yes. pip and vendor can co-exist.

That's the plan anyway.

Re: the name, @Qard suggested that the "gyp" in the name can stand for "Google Yeets Projects" which is an amazing name IMO as long as it's okay with Google folks (mean no offense, it's just a fact about the past of the project...) @MylesBorins thoughts?

@ryzokuken
Copy link
Contributor Author

@targos the document doesn't exactly say how many approvals are required or how long we should wait until we can proceed with the transfer.

@targos
Copy link
Member

targos commented Mar 10, 2020

There's a reference to another document which says we must wait 72 hours.

@richardlau
Copy link
Member

The link to the other document is broken (I've raised #476 to fix it).

@richardlau
Copy link
Member

https://github.com/nodejs/admin/blob/master/GITHUB_ORG_MANAGEMENT_POLICY.md#repositories (the corrected link) says (as @targos points out) to wait for 72 hours.

No approvals are required, just no objections in that 72 hour period.

@nschonni
Copy link
Member

Just curious if this is still a stopgap to keep it alive while a non-Python alternate is proposed?

@nschonni
Copy link
Member

The GYP license also only only seems to restrict the use of the Google trademark, rather than GYP name

https://chromium.googlesource.com/external/gyp/+/refs/heads/master/LICENSE

  • Neither the name of Google Inc. nor the names of its
    contributors may be used to endorse or promote products derived from
    this software without specific prior written permission.

@Qard
Copy link
Member

Qard commented Mar 12, 2020

Wouldn’t making it pip installable increase the likelihood people use it for other things, which we specifically don’t want? 🤔

@cclauss
Copy link

cclauss commented Mar 12, 2020

I doubt that anyone is going to find gyp just by search among the +222k packages on PyPI.

@ryzokuken
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests