Skip to content

move undici to the nodejs org #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcollina opened this issue Aug 12, 2020 · 7 comments
Closed

move undici to the nodejs org #541

mcollina opened this issue Aug 12, 2020 · 7 comments

Comments

@mcollina
Copy link
Member

A long time ago, I started developing https://github.com/mcollina/undici which is a replacement for Node.js core http.request and http.Agent. I think it has a reached a point of maturity where it would benefit to be in the Node.js organization instead.

wdyt?

cc nodejs/undici#312

@MylesBorins
Copy link
Contributor

Only thing I would want to ensure is that the code is properly licensed which it appears to be. LGTM

@mmarchini
Copy link
Contributor

SGTM. I'm transfering the issue to nodejs/admin as required by our GitHub Org Management Policy and repo transfer doc. It's also suggested the following documents exist in the repository:

  • CODE_OF_CONDUCT.md: it can be a reference to the Node.js Code of Conduct.
  • CONTRIBUTING.md: if there isn't one already, the contributing guide of Node.js core could be a good example. Consider including the Developer's Certificate of Origin section in the document to avoid potential copyright conflicts.
  • LICENSE, or other kind of documents that describe the license of the project.
  • README.md

Request is approved if there are no objections in 72h.

@mmarchini mmarchini transferred this issue from nodejs/TSC Aug 12, 2020
@mmarchini
Copy link
Contributor

cc @nodejs/community-committee @nodejs/tsc

@bnb
Copy link
Contributor

bnb commented Aug 19, 2020

SGTM :shipit:

mcollina added a commit to nodejs/undici that referenced this issue Aug 21, 2020
mcollina added a commit to nodejs/undici that referenced this issue Aug 21, 2020
@mcollina
Copy link
Member Author

@nodejs/tsc @nodejs/community-committee please review nodejs/undici#346.

@mhdawson
Copy link
Member

LGTM once nodejs/undici#346 lands (made one suggested change there)

mcollina added a commit to nodejs/undici that referenced this issue Aug 24, 2020
* Add Node.js meta documents

See: nodejs/admin#541
Fixes #312.

* Update CODE_OF_CONDUCT.md

Co-authored-by: Michael Dawson <[email protected]>

Co-authored-by: Michael Dawson <[email protected]>
@mcollina
Copy link
Member Author

Done.

I've also created a team with @ronag and myself in it with Maintain access to the undici repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants