Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find Jenkins worker IPs? #980

Closed
phillipj opened this issue Nov 6, 2017 · 3 comments
Closed

Find Jenkins worker IPs? #980

phillipj opened this issue Nov 6, 2017 · 3 comments

Comments

@phillipj
Copy link
Member

phillipj commented Nov 6, 2017

Any hints finding all Jenkins worker IPs?

Asking because we want to start whitelist the Jenkins hosts allowed to post inline PR status updates via the github-bot. The bot already has whitelisting implemented, but the list of IPs is currently not being set when starting the bot.

Refs nodejs/github-bot#142

@rvagg
Copy link
Member

rvagg commented Nov 6, 2017

@maclover7 were we able to restrict this to just the jenkins-workspace hosts? Otherwise it's going to be annoying whenever we add and remove IP addresses from the list. This happens every other week.

The IP addresses are here: https://github.com/nodejs/build/blob/master/ansible/inventory.yml, see the two jenkins-workspace hosts near the bottom, hopefully we can restrict it to just those. Otherwise you're going to have to add everything under the test section except for the requireio hosts which will come from the single ip address that resolves from vagg-arm.nodejs.org.

@maclover7
Copy link
Contributor

were we able to restrict this to just the jenkins-workspace hosts?

Yeah, the only machines running post-build-status-update and working with the bot should be jenkins-workspace machines as defined here.

@phillipj
Copy link
Member Author

phillipj commented Nov 7, 2017

Thanks! Opened #985 to provide those two current IPs to the bot.

@phillipj phillipj closed this as completed Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants