jenkins: whitelist IPs allowed to push status changes #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
phillipj
force-pushed
the
whitelist-jenkins-ips
branch
from
cbc986d to
a016a67
Compare
|
Fixed commented issues and force pushed. |
phillipj
force-pushed
the
whitelist-jenkins-ips
branch
from
a016a67 to
33db5c5
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This is needed to ensure not everyone on the internet can push an inline status to any PR if they know the bot URL.
phillipj
force-pushed
the
whitelist-jenkins-ips
branch
from
e1e8e4b to
fc72f9a
Compare
|
Rebased and force pushed to fix merge conflict with recent updates to master. |
phillipj
added a commit
to phillipj/build
that referenced
this pull request
Nov 7, 2017
Providing `$JENKINS_WORKER_IPS` environment variable at startup will activate the whitelist implemented in the bot, validating who's allowed pushed Jenkins job updates to inline PRs on github.com. Refs nodejs/github-bot#142
phillipj
added a commit
to phillipj/build
that referenced
this pull request
Nov 7, 2017
Providing `$JENKINS_WORKER_IPS` environment variable at startup will activate the whitelist implemented in the bot, validating who's allowed to pushed Jenkins job updates as inline PR statuses on github.com. Refs nodejs/github-bot#142
phillipj
added a commit
to phillipj/build
that referenced
this pull request
Nov 27, 2017
Providing `$JENKINS_WORKER_IPS` environment variable at startup will activate the whitelist implemented in the bot, validating who's allowed to pushed Jenkins job updates as inline PR statuses on github.com. Refs: nodejs/github-bot#142 PR-URL: nodejs#985 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
phillipj
added a commit
to nodejs/build
that referenced
this pull request
Nov 27, 2017
Providing `$JENKINS_WORKER_IPS` environment variable at startup will activate the whitelist implemented in the bot, validating who's allowed to pushed Jenkins job updates as inline PR statuses on github.com. Refs: nodejs/github-bot#142 PR-URL: #985 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to ensure not everyone on the internet can push an inline status to any PR if they know the bot URL.
@jbergstroem does this seem sufficient?
Closes #61