-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centos7 python 3.7 #1807
Centos7 python 3.7 #1807
Conversation
sam-github
commented
May 23, 2019
•
edited
Loading
edited
@mhdawson LGTY? @rvagg I don't know state of python3 on ARM, if you need it build because packages don't exist, this will do it. /to @cclauss @nodejs/python Also, I'm not sure who is working on updating python support, but note carefully the location of the python3. I'm not sure, is it unreasonably conservative? I could set the prefix to /usr/local to have it in the default path, but that would force there to be only one python3 on the system -- maybe that's OK, even desireable? |
FTR:
Once we decide on where python should be, I can update this PR, and apply it to the second centos7-ppc machine. |
This is great work! Thanks for doing it. I would prefer if the path to python2 and the path to python3 were the same. That is how it is done on most current distros (if they still ship legacy Python). |
They can't literally be the same paths, I don't think compiling something and installing it into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
on arm64 centos7 python34.aarch64 and python36.aarch64 are available, if we need 37 then I guess we need to go this route too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work @sam-github. Thanks a lot. I am also okay with this patch if the default installation location is /usr/local
. We wouldn't want to add the path of the new python to PATH
variable in our scripts.
I think this is landable, can I get a re-approval, please? @mhdawson you'll need to do the release machine, see below.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, lets do this on the release machine when we talk tomorrow about centos7 next steps
What is next step here? |
Applying the change to the release machine, and merging. |
Installs python3 in /usr/local/bin, as python3.7: % python3.7 --version Python 3.7.3 PR-URL: #1807