Removed macos10.14 machines from Orka in the Inventory #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
May 2, 2023
|
Seems like Node.js 16 is still tested with macos10.14: https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1014/ |
|
@targos should we change the target to macos10.15 for Node.js 16? I am not sure how, but I can investigate it 🤔 |
|
I went in a few Jenkins jobs (test-commit, test-commit-osx), and saved them to force removing the label from their configs so it should be fine for the next nightly runs. |
|
The official target for Node.js 16 is already 10.15 btw |
|
There are a few other things that can be cleaned up: |
|
Thanks a lot @targos! I will do a separate PRs with the changes 👍 |
UlisesGascon
added a commit
to UlisesGascon/build
that referenced
this pull request
May 3, 2023
This was referenced May 3, 2023
UlisesGascon
added a commit
to UlisesGascon/build
that referenced
this pull request
May 3, 2023
UlisesGascon
added a commit
that referenced
this pull request
May 4, 2023
* chore: remove legacy macos references in ansible roles * chore: remove legacy macos references in ansible roles Ref: #3327 (comment)
UlisesGascon
added a commit
that referenced
this pull request
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3087