github-bot: add $LOGS_DIR env variable #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had an issue with all logs written by the github-bot being deleted whenever the bot is re-deployed. That's especially bad when we want to debug issues happening a few days ago, which would be impossible if we've done a re-deploy in between. The root cause of that issue is that we clone the github-bot repo onto the server and write logs to `./logs` of that cloned repo. Whenever we re-deploy we run `git clean -fdx` before updating the repo, resulting in any untracked files to be deleted. By adding a `$LOGS_DIR` pointing to a directory *outside* the git repo, will prevent logs being deleted cause of re-deploys.
phillipj
added a commit
to phillipj/github-bot
that referenced
this pull request
Jan 29, 2017
The main objective behind these changes are to not write logs into the project's `./logs` directory, cause that ends up being deleted whenever the bot is re-deployed. Requires deployment changes: nodejs/build#602
phillipj
added a commit
to phillipj/github-bot
that referenced
this pull request
Jan 29, 2017
The main objective behind these changes are to not write logs into the project's `./logs` directory, cause that ends up being deleted whenever the bot is re-deployed. Requires deployment changes: nodejs/build#602
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Yupp, and it's already there. The auto deployment hook we've got puts a log file there. github-bot/ansible-playbook.yaml#L45 & github-bot/ansible-vars.yaml#L10 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had an issue with all logs written by the github-bot being deleted whenever the bot is re-deployed. That's especially bad when we want to debug issues happening a few days ago, which would be impossible if we've done a re-deploy in between.
The root cause of that issue is that we clone the github-bot repo onto the server and write logs to
./logsof that cloned repo. Whenever we re-deploy we rungit clean -fdxbefore updating the repo, resulting in any untracked files to be deleted.By adding a
$LOGS_DIRpointing to a directory outside the git repo,will prevent logs being deleted cause of re-deploys.
P.S. we haven't added support for$LOGS_DIRin the bot yet, will do that as soon as this lands.