-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add pipeline script for node-inspect #956
Conversation
I'm really tempted to walk back on the declarative syntax here given the amount of repetition once all possible architectures are added. Unless we'd move that logic to an inline |
This is what came out https://ci.nodejs.org/job/node-inspect/2/flowGraphTable/ |
Can someone give nodejs/node-inspect#53 a quick look to get the latest |
For reference, here's how an example run renders in blue ocean when I was testing this script locally: That view makes the job output a lot easier to consume. Unfortunately the out-of-the-box experience of looking at parallel stages in Jenkins is pretty bad (by which I mean pretty much unusable). :( |
It's not that bad, it's just not trivial to find:
|
Yes, I know. But with non-trivial workflows (e.g. parallel + anything happening afterwards) the flattened stage view becomes super confusing [especially if any stage name isn't globally unique]. This isn't a problem yet here (since it has just two fake "architectures" right now and nothing happening afterwards) but it won't get any better the more complex the workflow gets. Though maybe it'll be fine for node's builds. I might be scared by our internal deployment pipeline builds (with multiple validation stages consisting of parallelized things). |
@jkrems the log visibility issue was brought up by @joaocgreis and AFAIK is the last hindrance for full adoption. On the other hand the step tree: tl;dr IMHO we should move away from log-based-groking to using parsing plugins (like tap or tap2junit), while also look-for/develop a better log parser. |
1c9f355
to
4781766
Compare
696b8c3
to
1fb7b60
Compare
Stale pipeline PR related to the pipeline experiment. |
Highly WIP but I guess it's better to put it here before I lose my local docker container...
See: