-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve support of backtick strings #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, I think.
What you could do for tests is add some trivial commits to this PR and test against the commits that this comprises. See how the tests currently do it.
I'm going to suggest that the next release will be a semver-minor, so you could bake that into your test case with a --start-ref and --end-ref and add commits to this PR with just a change of whitespace in this file, or the README, that have commit messages that form part of the test suite. That's perfectly OK to do here. If we have any awkward breakage during the next release we can sort that out later.
Have a quick go, if it gets too complicated then no big deal I think but it would be nice to see how this works and bake it into the tests.
looks good I think but the test text fails lint with unnecessary escapes |
Only supports code span delimited with a single backtick char and gives up if it finds an edge case.
0ee4588
to
fd7162f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet
ok, github didn't like the empty commits, I had to reconstruct that all locally but it should be publisahed now as 2.6.0 |
Alternate to #94
Only supports code span delimited with a single backtick char and gives up if it finds an edge case.
List of unsupported markdown-compliant edge cases I could think of:
I wasn't sure how to add tests for that, but it works from what I have tested locally.