Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Tag Change #937

Closed
kotva006 opened this issue Nov 27, 2018 · 7 comments
Closed

Docker Tag Change #937

kotva006 opened this issue Nov 27, 2018 · 7 comments

Comments

@kotva006
Copy link

It looks like the tags were changed recently which caused a breaking change with out build/application.
We have been using node:dubnium for the past week with no problems, and then today our builds failed due to the docker container.
It appears the node:dubnium was changed to point to debian stretch instead of debian jessie. Jessie had some files that our application depended on that stretch does not.
We have fixed the issue for our build by switching to use node:dubnium-jessie instead.
Not sure if this was an intended change (or if we were using tags wrong). Just figured I should let people know that a tag change had some repercussions.

@tvainika
Copy link
Contributor

Our Dockerfiles have had things like this:

FROM node:8 as run_deps
...
RUN apt-get -qq update && apt-get -qq install -y \
  libssl-dev \
  openssl && \
  apt-get -qq clean && \
  rm -rf /var/lib/apt/lists/*

Now that Debian 9 stretch has libssl-dev pointing to v1.1.0f instead of v1.0.x as it was in Debian 8 jessie, it means that our builds will link native libraries against OpenSSL v1.1 which conflicts with Node v8.13 being linked against OpenSSL v1.0.

Changing tags like this is really not compatible upgrade. It breaks quite lot of builds around there.

@ACPrice
Copy link

ACPrice commented Nov 27, 2018

I'm wondering if this issue is affecting my builds, too. I have a repo that pulls node:boron and we're homing in on the node image as the culprit responsible for a new error.

@LaurentGoderre
Copy link
Member

We are improving how the tags are handled between the different versions of Debian in #850. We will be providing tags to pin the version of Debian while the tag without the prefix will refer to the default version of Debian, which will change over time.

@shrikrishnaholla
Copy link

We're facing issues with our builds too. Wondering if the tagging refactor being mentioned here has anything to do with it #936

@LaurentGoderre
Copy link
Member

@kotva006 @tvainika the default image was changed to Debian Stretch because Jessie is EOL. You can however fix your build by pointing to node:8-jessie

@LaurentGoderre
Copy link
Member

Can we close this since now you can easily target which debian version you want to use?

@kotva006
Copy link
Author

Yeah you can close it. My main purpose was to just let people know going from Jessie to Stretch was a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants