Add buster :) #1055
Add buster :) #1055
Conversation
|
This PR changes default Debian version of Node.js 8.x and Node.js 10.x images, which are under active LTS maintenance. Earlier when Debian 8 jessie LTS support ended, Node.js 8.x and Node.js 9.x images changed underlying operating system version causing issues #936, #937 and #940 opened as expectations were not met. In my opinion both Node.js 8.x and Node.js 10.x default images should be kept aliases to whatever operating system version those were first released during LTS start. That is Debian normal security support promises Debian 9 stretch support until June 2020, and Debian LTS security support up to June 2022 for Debian 9 stretch. Node.js 10.x LTS ends 2021-04-01 and Node.js 8.x LTS ends as soon as 2019-12-31. However Node.js 12.x LTS ends later than Debian 9 stretch LTS, so it might be preferred solution to switch Also it would be useful to write down the principles how the operating system version are selected and updated just like CONTRIBUTING.md describes update cycle for Node.js, NPM and Yarn. This is just my 0.02 cents as I was bitten by tag change as I explained in my comment for #937. |
| @@ -1,4 +1,4 @@ | |||
| baseuri https://nodejs.org/dist | |||
| default_variant stretch | |||
| default_variant buster | |||
There was a problem hiding this comment.
I'm fine with adding a buster variant, but please don't change the default version.
| - update.sh . alpine # Update the alpine variant for all versions | ||
| - update.sh -t # Update .travis.yml only | ||
| - update.sh # Update all images | ||
| - update.sh -s # Update all images, skip updating Alpine and Yarn |
There was a problem hiding this comment.
Please remove these whitespace changes.
| @@ -17,7 +17,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ | |||
| && rm "node-v$NODE_VERSION-linux-$ARCH.tar.xz" SHASUMS256.txt \ | |||
| && ln -s /usr/local/bin/node /usr/local/bin/nodejs | |||
|
|
|||
| ENV YARN_VERSION 1.6.0 | |||
| ENV YARN_VERSION 1.16.0 | |||
There was a problem hiding this comment.
Please remove this change. This PR should only be about adding buster.
| @@ -1,4 +1,4 @@ | |||
| FROM buildpack-deps:jessie | |||
| FROM buildpack-deps:stretch | |||
There was a problem hiding this comment.
Drop this change, it doesn't' belong here.
| @@ -17,7 +17,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ | |||
| && rm "node-v$NODE_VERSION-linux-$ARCH.tar.xz" SHASUMS256.txt \ | |||
| && ln -s /usr/local/bin/node /usr/local/bin/nodejs | |||
|
|
|||
| ENV YARN_VERSION 1.12.3 | |||
| ENV YARN_VERSION 1.16.0 | |||
| @@ -1,4 +1,4 @@ | |||
| FROM node:8.16.0-stretch | |||
| FROM node:8.16.0-buster | |||
There was a problem hiding this comment.
Drop this change please. This PR should not be changing the default variant.
Also the onbuild variant is deprecated, so this change has little value anyway.
| @@ -45,7 +45,7 @@ RUN buildDeps='xz-utils' \ | |||
| && apt-get purge -y --auto-remove $buildDeps \ | |||
| && ln -s /usr/local/bin/node /usr/local/bin/nodejs | |||
|
|
|||
| ENV YARN_VERSION 1.15.2 | |||
| ENV YARN_VERSION 1.16.0 | |||
| @@ -42,7 +42,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ | |||
| && rm "node-v$NODE_VERSION-linux-$ARCH.tar.xz" SHASUMS256.txt.asc SHASUMS256.txt \ | |||
| && ln -s /usr/local/bin/node /usr/local/bin/nodejs | |||
|
|
|||
| ENV YARN_VERSION 1.15.2 | |||
| ENV YARN_VERSION 1.16.0 | |||
| @@ -144,24 +144,17 @@ jobs: | |||
|
|
|||
| - stage: Build | |||
| before_script: *auto_skip | |||
| name: 11 on alpine | |||
There was a problem hiding this comment.
Please revert this. 11 should not be dropped from travis as part of this PR
| @@ -144,24 +144,17 @@ jobs: | |||
|
|
|||
| - stage: Build | |||
| before_script: *auto_skip | |||
| name: 11 on alpine | |||
| name: 10 on buster | |||
There was a problem hiding this comment.
These and the following changes to add the buster variant should also be in the travis.yml.template file which is the source template for the .travis.yml file.
No description provided.