-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node.js v10.x to v10.3.0 #762
Conversation
PeterDaveHello
commented
May 29, 2018
- https://github.com/nodejs/node/releases/tag/v10.3.0
- https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V10.md#10.3.0
Docker service on Travis CI seems to be down ... lol |
I think it's the removal of Docker service in .travis.yml caused the problem ... ? |
Revert bffff57 and see the result ... |
0a60e31
to
9c37370
Compare
@LaurentGoderre is it correct that v10 builds are so fast? I think they are skipped? |
Yeah, it needs to be brought back to enable the Docker service: https://docs.travis-ci.com/user/docker/ Also we should drop |
Just needs a rebase with latest master. Hopefully that should kick off a new build and everything else will work |
I think Travis had momentary connectivity issue that caused the build issue. |
87bcffa
to
bbae51a
Compare
Maybe, but that doesn't jive with what their docs say and they haven't posted any issues to their status. Plus, this doesn't look like a connectivity issue: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
ERRO[0000] failed to dial gRPC: cannot connect to the Docker daemon. Is 'docker daemon' running on this host?: dial unix /var/run/docker.sock: connect: no such file or directory |
Travis CI seems to have Internet connectivity issue that caused some http(s) connection timeout, shouldn't cause new problem. @LaurentGoderre https://travis-ci.org/nodejs/docker-node/builds/385380587 looks those builds are not properly skipped? |
One of the tests failed so the Pr never happened: https://travis-ci.org/nodejs/docker-node/builds/385396993 Looks like some odd network issue. I'll work on the docker hub pr |
I'm pretty confident that the above travis-ci issue was caused by the npm registry issues: https://www.traviscistatus.com/incidents/bbp3rj9jktnd |