Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node.js v10.x to v10.3.0 #762

Merged
merged 1 commit into from
May 29, 2018
Merged

Update node.js v10.x to v10.3.0 #762

merged 1 commit into from
May 29, 2018

Conversation

@PeterDaveHello PeterDaveHello requested a review from a team May 29, 2018 17:45
LaurentGoderre

This comment was marked as off-topic.

@PeterDaveHello
Copy link
Member Author

Docker service on Travis CI seems to be down ... lol

SimenB

This comment was marked as off-topic.

@PeterDaveHello
Copy link
Member Author

I think it's the removal of Docker service in .travis.yml caused the problem ... ?

@PeterDaveHello
Copy link
Member Author

Revert bffff57 and see the result ...

@PeterDaveHello
Copy link
Member Author

@LaurentGoderre is it correct that v10 builds are so fast? I think they are skipped?

https://travis-ci.org/nodejs/docker-node/builds/385329492

@chorrell
Copy link
Contributor

Yeah, it needs to be brought back to enable the Docker service:

https://docs.travis-ci.com/user/docker/

Also we should dropsudo: false: https://docs.travis-ci.com/user/reference/overview/#For-a-particular-.travis.yml-configuration

@chorrell
Copy link
Contributor

Just needs a rebase with latest master. Hopefully that should kick off a new build and everything else will work

@LaurentGoderre
Copy link
Member

I think Travis had momentary connectivity issue that caused the build issue.

@chorrell
Copy link
Contributor

Maybe, but that doesn't jive with what their docs say and they haven't posted any issues to their status. Plus, this doesn't look like a connectivity issue:

Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
ERRO[0000] failed to dial gRPC: cannot connect to the Docker daemon. Is 'docker daemon' running on this host?: dial unix /var/run/docker.sock: connect: no such file or directory 

@PeterDaveHello
Copy link
Member Author

Travis CI seems to have Internet connectivity issue that caused some http(s) connection timeout, shouldn't cause new problem.

@LaurentGoderre https://travis-ci.org/nodejs/docker-node/builds/385380587 looks those builds are not properly skipped?

@PeterDaveHello PeterDaveHello merged commit cefe862 into master May 29, 2018
@PeterDaveHello PeterDaveHello deleted the update-node.js branch May 29, 2018 21:07
@chorrell
Copy link
Contributor

One of the tests failed so the Pr never happened:

https://travis-ci.org/nodejs/docker-node/builds/385396993

Looks like some odd network issue.

I'll work on the docker hub pr

@chorrell
Copy link
Contributor

I'm pretty confident that the above travis-ci issue was caused by the npm registry issues: https://www.traviscistatus.com/incidents/bbp3rj9jktnd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants