This repository was archived by the owner on Apr 16, 2020. It is now read-only.
WIP: Specify file resolution and exports #22
Closed
+377
−1,937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
previously requested changes
Dec 19, 2018
guybedford
force-pushed
the
irp-exports
branch
from
3fd47d4 to
beb1d1a
Compare
guybedford
dismissed
devsnek’s stale review
implementation already does this, spec corrected.
guybedford
force-pushed
the
irp-exports
branch
3 times, most recently
from
5a38f6c to
86557e7
Compare
weswigham
reviewed
Dec 19, 2018
| > 1. Return _pjson_. | ||
| HAS_ESM_PROPERTIES(_pjson_) | ||
| > 1. If _pjson_ is not **null** and _pjson.exports_ is a String or Object, then |
There was a problem hiding this comment.
I'm going to continue to insist that exports is useful for non-esm packages and shouldn't be an esm marker.
There was a problem hiding this comment.
It's also worth noting that this has an impact on how node deals with package.json from a performance standpoint.
MylesBorins
force-pushed
the
modules-lkgr
branch
from
96eebd2 to
cc83869
Compare
|
@guybedford gone ahead and rebase this against the new modules-lkgr |
MylesBorins
force-pushed
the
irp-exports
branch
from
86557e7 to
16c7647
Compare
nodejs-ci
force-pushed
the
modules-lkgr
branch
7 times, most recently
from
49aef18 to
7d7c17c
Compare
nodejs-ci
force-pushed
the
modules-lkgr
branch
8 times, most recently
from
9117c25 to
f5404c4
Compare
nodejs-ci
force-pushed
the
modules-lkgr
branch
2 times, most recently
from
230f58d to
127e0d5
Compare
MylesBorins
force-pushed
the
modules-lkgr
branch
from
127e0d5 to
bf69a15
Compare
guybedford
force-pushed
the
irp-exports
branch
from
16c7647 to
e69ac4e
Compare
MylesBorins
force-pushed
the
modules-lkgr
branch
from
bf69a15 to
519ea5d
Compare
Refs: nodejs/modules#180 PR-URL: nodejs#6 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Refs: nodejs/modules#180 PR-URL: nodejs#6 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Refs: nodejs/modules#180 PR-URL: nodejs#6 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Refs: nodejs/modules#180 PR-URL: nodejs#6 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: nodejs#6 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: nodejs#6 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: nodejs#6 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
force-pushed
the
modules-lkgr
branch
from
519ea5d to
046cec6
Compare
guybedford
force-pushed
the
irp-exports
branch
from
e69ac4e to
73fb81d
Compare
nodejs-ci
force-pushed
the
modules-lkgr
branch
from
046cec6 to
a806a61
Compare
MylesBorins
force-pushed
the
modules-lkgr
branch
from
a806a61 to
576efa4
Compare
nodejs-ci
force-pushed
the
modules-lkgr
branch
2 times, most recently
from
014cd60 to
acdf4e9
Compare
|
Replaced by #28. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines the spec for the file resolution proposal in #19, with the exports spec from https://github.com/jkrems/proposal-pkg-exports/.
I've put together an experimental implementation of this spec at https://github.com/guybedford/node/tree/irp-implementation if anyone wants to try it out.
Feedback welcome.