Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destructure Jenkins build result after knowing it's not an error #237

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Destructure Jenkins build result after knowing it's not an error #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions scripts/trigger-jenkins-build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,18 @@ function triggerBuildIfValid (options) {
return logger.debug(`Ignoring comment to me by @${options.author} because they are not a repo collaborator`)
}

triggerBuild(options, function onBuildTriggered (err, { jobName, jobId }) {
const jobUrl = `https://ci.nodejs.org/job/${jobName}/${jobId}`
let body = `Lite-CI: ${jobUrl}`
triggerBuild(options, function onBuildTriggered (err, result) {
let body = ''

if (err) {
logger.error(err, 'Error while triggering Jenkins build')
body = 'Sadly, an error occurred when I tried to trigger a build. :('
} else {
const jobUrl = `https://ci.nodejs.org/job/${result.jobName}/${result.jobId}`
logger.info({ jobUrl }, 'Jenkins build started')
body = `Lite-CI: ${jobUrl}`
}

createPrComment(options, body)
})
})
Expand Down