Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: how to create a new release. #18

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

NickNaso
Copy link
Member

This PR add the guide that explain how to create and publish a new release.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Use the output generated by **changelog maker** to update the
[CHANGELOG.md][] following the style used in publishing the previous release.

* Add any new contributors to the "contributors" section in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find steps to create git tags for the release. Should we document that the tag should be created along with package.json version updates by npm version patch or npm version minor?

Copy link
Member Author

@NickNaso NickNaso Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag will be created by GitHub while creating new release.
This will be address doing this step:

  • Create a release in Github (look at existing releases for an example).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, SGTM.

* Use the output generated by **changelog maker** to update the
[CHANGELOG.md][] following the style used in publishing the previous release.

* Add any new contributors to the "contributors" section in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, SGTM.

@legendecas legendecas merged commit 069c3eb into nodejs:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants