Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update headers from nodejs/node tag v23.1.0 #54

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Automated sync of headers with Node.js v23.1.0

@github-actions github-actions bot added the headers PRs for header syncs label Oct 25, 2024
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@KevinEady just to confirm you think this looks right based on your latest update to the tooling?

@KevinEady
Copy link
Contributor

@mhdawson no, #52 needs to land first.

@mhdawson
Copy link
Member

@KevinEady ok landed #52.

@legendecas
Copy link
Member

I triggered https://github.com/nodejs/node-api-headers/actions/runs/11576046650 manually but it seems like this PR didn't get updated.

@KevinEady
Copy link
Contributor

It's done by branch name. Closing this PR + branch and rerunning...

@KevinEady KevinEady closed this Oct 29, 2024
@KevinEady KevinEady deleted the update-headers/v23.1.0 branch October 29, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
headers PRs for header syncs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants