Add helper scripts for updating headers and symbols.js #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update-headers.js: Fetch latest headers from nodejs/node - write-symbols.js: Use clang to process headers to create symbols.js
KevinEady
commented
Dec 30, 2022
Sample Action RunsDo not create PR if branch exists
Do not create PR if no changes
Run on daily schedule at 00:00 UTC |
- Add 'use strict' - Make write-symbols main() async
legendecas
approved these changes
Jan 10, 2023
- Remove double string interpolation Co-authored-by: Chengzhong Wu <[email protected]>
NickNaso
approved these changes
Jan 13, 2023
|
@KevinEady I think when we discussed in a Node-API meeting you were going to update to remove the Experimental part of the headers. Was that added and I just can't find it? |
|
@KevinEady, I found the part that removes the experimental functions from the symbols but I think we also should do that in the header file as well. |
Addressed in 41f0767...36a1e92 This action run https://github.com/KevinEady/node-api-headers/actions/runs/4174541956/jobs/7228252444 created PR https://github.com/KevinEady/node-api-headers/pull/10/files?diff=split&w=1 |
NickNaso
approved these changes
Feb 14, 2023
legendecas
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new scripts runnable via
npm:npm run-script update-headers: Fetch latest headers from nodejs/node and removesNAPI_EXPERIMENTALpreprocessor checks of#ifdefand#ifndef, assuming it is not defined.npm run-script write-symbols: Useclangto process headers to createsymbols.jsThis PR also adds a GitHub Actions workflow for performing the sync on a daily schedule (also can be manually triggered).
Relates: #2