This repository was archived by the owner on Oct 15, 2020. It is now read-only.
lib: make sure console is writable
#518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally I'd like to upstream the lib change, but it probably makes sense to float the patch for now. |
|
Upstream PR: nodejs/node#20185 |
MSLaguana
approved these changes
Apr 21, 2018
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Apr 21, 2018
The console property should not be enumerable according to the W3C spec. PR-URL: nodejs#518 Reviewed-By: Seth Brenith <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Apr 21, 2018
The code currently assumes that `console` is already writable, but that's only if it was previously defined as writable. If it hasn't already been defined then the default value is false. PR-URL: nodejs#518 Reviewed-By: Seth Brenith <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Apr 22, 2018
The console property should not be enumerable according to the W3C spec. PR-URL: nodejs#518 Reviewed-By: Seth Brenith <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Apr 22, 2018
The code currently assumes that `console` is already writable, but that's only if it was previously defined as writable. If it hasn't already been defined then the default value is false. PR-URL: nodejs#518 Reviewed-By: Seth Brenith <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
|
This should be closed now, right? |
The code currently assumes that `console` is already writable, but that's only if it was previously defined as writable. If it hasn't already been defined then the default value is false. PR-URL: nodejs#518 Reviewed-By: Seth Brenith <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
|
I had to drop the inspector change, there's something very odd going on that's causing a test break. Just this change should be good enough, so I'll split out the other change and investigate. |
|
@jackhorton I'm still planning to land this here since the node change will take a couple days to land. |
kfarnung
added a commit
that referenced
this pull request
Apr 22, 2018
The code currently assumes that `console` is already writable, but that's only if it was previously defined as writable. If it hasn't already been defined then the default value is false. PR-URL: #518 Reviewed-By: Seth Brenith <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Jun 29, 2018
The console property should not be enumerable according to the W3C spec. PR-URL: nodejs#518 Reviewed-By: Seth Brenith <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code currently assumes that
consoleis already writable, butthat's only if it was previously defined as writable. If it hasn't
already been defined then the default value is false.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes