-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get-metadata: add "Refs:" in metadata #117
Comments
Strange, this feature is already implemented and is supposed to work, but I can't get Refs in metadata either. |
@Tiriel Did you have a chance to look into this? |
@joyeecheung Not yet, had a pretty busy week. Putting it on my schedule for tonight! |
The reason Line 48 in edd107a
The query selector at line 48 Way to fix this issue is just to remove \cc @joyeecheung @Tiriel |
Still looking for a propoer way to parse the links recursively, I'm on it ;) |
@cPhost SGTM |
Don't know what I did last night but I was way too far... Opening a PR. Removing the class was all that was needed it seems. Tests OK and example given OK too. |
* links: removed unused class, allows parsing non github refs Fixes: #117 * test: added test for new refs parsing
* links: removed unused class, allows parsing non github refs Fixes: nodejs/node-core-utils#117 * test: added test for new refs parsing
* links: removed unused class, allows parsing non github refs Fixes: nodejs/node-core-utils#117 * test: added test for new refs parsing
* links: removed unused class, allows parsing non github refs Fixes: nodejs/node-core-utils#117 * test: added test for new refs parsing
* links: removed unused class, allows parsing non github refs Fixes: nodejs/node-core-utils#117 * test: added test for new refs parsing
* links: removed unused class, allows parsing non github refs Fixes: nodejs/node-core-utils#117 * test: added test for new refs parsing
Example: nodejs/node#17107
IIRC, nodejs/node-review adds this data.
The text was updated successfully, but these errors were encountered: