Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix install: add iojs support #669

Closed
wants to merge 1 commit into from
Closed

fix install: add iojs support #669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,15 @@ function install (gyp, argv, callback) {
}
}

var distUrl = gyp.opts['dist-url'] || gyp.opts.disturl || 'https://nodejs.org/dist'
var distUrl = gyp.opts['dist-url'] || gyp.opts.disturl

if (!distUrl) {
if (semver.satisfies(version, '>=1.0.0')) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not reliable if NodeJS released v1.0.0 someday, I prefer process.release.node === 'io.js'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Node.js" 1.0.0 will never be released. As a TSC member, I can authoritatively say that. :)

Also, io.js is node.js now: https://github.com/nodejs/node

However, version detection still isn't a great way of doing things, though it could for for io.js 1.0.0> <3.0.0. As @camsong said, what we really should be doing now is detecting 3.0.0's process.release :)

distUrl = 'https://iojs.org/dist'
} else {
distUrl = 'https://nodejs.org/dist'
}
}

// Determine which node dev files version we are installing
var versionStr = argv[0] || gyp.opts.target || process.version
Expand Down