Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

Unit test failure (Windows): simple/test-require-resolve #5073

Closed
sblom opened this issue Mar 18, 2013 · 1 comment
Closed

Unit test failure (Windows): simple/test-require-resolve #5073

sblom opened this issue Mar 18, 2013 · 1 comment
Labels

Comments

@sblom
Copy link

sblom commented Mar 18, 2013

=== release test-require-resolve ===
Path: simple/test-require-resolve
module.js:340
    throw err;
          ^
Error: Cannot find module '../fixtures/nested-index/one'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.require.resolve (module.js:384:19)
    at Object.<anonymous> (E:\src\node\master\test\simple\test-require-resolve.js:32:22)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:903:3
Command: e:\src\node\master\Release\node.exe E:\src\node\master\test\simple\test-require-resolve.js
sblom added a commit that referenced this issue Mar 19, 2013
Fixes #5071, #5073.

* Normalize capitalization of drive letter
* Fix `exit()` typo in failure path
* Ignore symlink tests (Windows) if not elevated

The `test_relative_input_cwd()` test was failing on Windows when
`skipSymlinks` was `true`. So we won't run it if `skipSymlinks` is
`true`.

When it failed, the unhandled error caused Node to die before
having a chance to clean up, which resulted in two files missing
in subsequent unit tests:

 * `test/fixtures/nested-index/one/hello.js`
 * `test/fixtures/nested-index/one/index.js`

We should probably find a way to isolate this test from the other
test (`simple/test-module-loading`) that was failing when this test
poluted the disk state.
@sblom sblom closed this as completed Mar 19, 2013
@obastemur
Copy link

Similar .NET Framework features and their behavior;

var path = @"C:\ddd\b\..\qq"; var canonicalPath = new Uri(path).LocalPath; // it results in "C:\ddd\qq" for C#.NET

var path1 = @"C:\abc"; var path2 = @"DeF"; var result = System.IO.Path.Combine(path1, path2); // it results in "C:\abc\DeF"

@sblom could you please explain the reasoning behind 'driveLetter.toLowerCase' update ?

richardlau pushed a commit to ibmruntimes/node that referenced this issue Feb 18, 2016
Fix missing links. Fix styling of printf() - once nodejs#5073 lands,
link to man page will be auto-generated. Fix several typos.

PR-URL: nodejs/node#5225
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit to ibmruntimes/node that referenced this issue Feb 23, 2016
Fix missing links. Fix styling of printf() - once nodejs#5073 lands,
link to man page will be auto-generated. Fix several typos.

PR-URL: nodejs/node#5225
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit to ibmruntimes/node that referenced this issue Feb 23, 2016
Fix missing links. Fix styling of printf() - once nodejs#5073 lands,
link to man page will be auto-generated. Fix several typos.

PR-URL: nodejs/node#5225
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit to ibmruntimes/node that referenced this issue Mar 9, 2016
Fix missing links. Fix styling of printf() - once nodejs#5073 lands,
link to man page will be auto-generated. Fix several typos.

PR-URL: nodejs/node#5225
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants