This repository was archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Unit test failure (Windows): simple/test-require-resolve #5073
Labels
Comments
sblom
added a commit
that referenced
this issue
Mar 19, 2013
Fixes #5071, #5073. * Normalize capitalization of drive letter * Fix `exit()` typo in failure path * Ignore symlink tests (Windows) if not elevated The `test_relative_input_cwd()` test was failing on Windows when `skipSymlinks` was `true`. So we won't run it if `skipSymlinks` is `true`. When it failed, the unhandled error caused Node to die before having a chance to clean up, which resulted in two files missing in subsequent unit tests: * `test/fixtures/nested-index/one/hello.js` * `test/fixtures/nested-index/one/index.js` We should probably find a way to isolate this test from the other test (`simple/test-module-loading`) that was failing when this test poluted the disk state.
Similar .NET Framework features and their behavior;
@sblom could you please explain the reasoning behind 'driveLetter.toLowerCase' update ? |
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this issue
Feb 18, 2016
Fix missing links. Fix styling of printf() - once nodejs#5073 lands, link to man page will be auto-generated. Fix several typos. PR-URL: nodejs/node#5225 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this issue
Feb 23, 2016
Fix missing links. Fix styling of printf() - once nodejs#5073 lands, link to man page will be auto-generated. Fix several typos. PR-URL: nodejs/node#5225 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this issue
Feb 23, 2016
Fix missing links. Fix styling of printf() - once nodejs#5073 lands, link to man page will be auto-generated. Fix several typos. PR-URL: nodejs/node#5225 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this issue
Mar 9, 2016
Fix missing links. Fix styling of printf() - once nodejs#5073 lands, link to man page will be auto-generated. Fix several typos. PR-URL: nodejs/node#5225 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: