build: install node and static library headers #6332
Conversation
|
This should probably be opt-in with a configure flag ( |
|
This is to restore the functionality that we used to have in v0.8 largely, it is useful for everyone, but especially helpful for platform distributors, these are tiny files and I see no reason for it to be opt in, especially since it will be most helpful moving forward for node-gyp. |
|
It feels strange doing an #include <node/node_buffer.h> Feel like this needs some more thinking through. Like, just include |
|
You can find a more elaborate reply here but the tl;dr is "-1, do not want." |
|
I still feel link bundling the headers, gzipped, in the node executable would be way more reliable. So basically a -1 from me as well for the reasons that @bnoordhuis has been pointing out. Plus we gotta remember about Windows, which I think you guys are starting to overlook ;) |
|
I'm still not for how we'd be exporting the headers. having |
|
We can talk about changing the names in master but for backward compat |
| files = [dirpath + '/' + f for f in filenames if f.endswith('.h')] | ||
| ret[dest + dirpath.replace(path, '')] = files | ||
| for subdir, files in ret.items(): | ||
| action(files, subdir + '/') |
|
Linux part LGTM |
|
after discussion with @isaacs this was partially landed, restoring the unix portions of this in 32478ac the windows portions will land after I've addressed @piscisaureus's concerns |
|
@misterdjules @orangemocha ... any reason to keep this one open? I can't imagine any. |
|
Closing this here. If there is any reason to pursue this, a new PR would need to be opened in nodejs/master once the v0.10 branch moves over. |
fixes #5112