This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Buffer doc fixes #8881
Closed
Buffer doc fixes #8881
+29
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(there's an alternate proposed fix here: https://github.com/zetxx/node/commit/c691bf340effde7974e25e3be2aa409bf14 c2012)
This reverts commit 8360257.
This reverts commit f5620ba.
|
You need to squash and force push this PR, its a mess. |
|
Yes yes... will close this one and just redo it. Needed to clean up a few other things anyway. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer doc fixes addressing and #8857 #8859 . Specifically, improvements to discussion on overlapping buffers (including a new example) and toString arguments (including a new example)