Build failure on SmartOS (6.2)

[targos]

CI run: https://ci.nodejs.org/job/node-test-commit-smartos/10884/nodes=smartos15-64/console

Error:

  touch /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node_dtrace_provider.stamp
dtrace: failed to compile script src/v8ustack.d: line 293: failed to resolve V8DBG_FRAMETYPE_ENTRYCONSTRUCTFRAME: Unknown variable name
node_dtrace_ustack.target.mk:26: recipe for target '/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node/src/node_dtrace_ustack.o' failed
make[2]: *** [/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node/src/node_dtrace_ustack.o] Error 1

@nodejs/platform-smartos

[cjihrig]

I'll take a look.

[targos]

This is still happening. Latest run: https://ci.nodejs.org/job/node-test-commit-smartos/11137/nodes=smartos16-64/console

[geek]

Fixed in the latest: https://ci.nodejs.org/job/node-test-commit-smartos/11139/ via nodejs/node@44f5ffe

[targos]

I'm reopening because the build is still failing with this commit and with the same error message: https://ci.nodejs.org/job/node-test-commit-smartos/11145/

[targos]

Fixed by nodejs/node@50cc6c7

[misterdjules]

@targos Just to make sure we're on the same page, some of the commits that fix the build issue on SmartOS are temporary fixes (like f6bd6af), and some of them may not have been through a standard review/testing process (like nodejs/node@50cc6c7).

@cjihrig, myself and others have started to take a closer look at fixing the DTrace and post-mortem debugging issues with recent V8 versions, and we should be able to come up with less temporary fixes soon.

[targos]

@misterdjules all commits that are on canary-base but not on master can be considered temporary fixes. This branch only exists to collect fixes that the bot can cherry-pick to this repository for the canary updates/tests/nightly.

They will go through a standard review process when a PR is opened in the node repository to update V8 on master or they will be removed once the changes are upstreamed to V8 (if applicable).