Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ustack: update offset identifiers #17

Closed
wants to merge 1 commit into from
Closed

ustack: update offset identifiers #17

wants to merge 1 commit into from

Conversation

geek
Copy link
Member

@geek geek commented Aug 28, 2017

Fixes #16

@geek geek requested a review from targos August 28, 2017 18:24
@targos
Copy link
Member

targos commented Aug 28, 2017

@geek thank you! Feel free to push this commit on top of node's canary-base branch. It will be cherry-picked by the bot tomorrow.
Note that this (and also 1adfaa0 in some form, see #8) should be upstreamed to V8 so we don't have to float the patches.

@geek
Copy link
Member Author

geek commented Aug 28, 2017 •
edited
Loading

@targos done 44f5ffebdfae8fc17336328e2fabbe1ed038f38b

@geek geek closed this Aug 28, 2017
@davidmarkclements davidmarkclements mentioned this pull request Aug 29, 2017
Closed
@cjihrig cjihrig mentioned this pull request Aug 29, 2017
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos Awaiting requested review from targos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geek @targos