Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure on SmartOS #21

Closed
targos opened this issue Oct 26, 2017 · 6 comments
Closed

Build failure on SmartOS #21

targos opened this issue Oct 26, 2017 · 6 comments

Comments

@targos
Copy link
Member

targos commented Oct 26, 2017

https://ci.nodejs.org/job/node-test-commit-smartos/12561/nodes=smartos15-64/console

Error:

dtrace: failed to compile script src/v8ustack.d: line 358: failed to resolve V8DBG_TYPE_CODE__CODE_TYPE: Unknown variable name
node_dtrace_ustack.target.mk:26: recipe for target '/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node/src/node_dtrace_ustack.o' failed
make[2]: *** [/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node/src/node_dtrace_ustack.o] Error 1

/cc @nodejs/platform-smartos
@cjihrig
Copy link

cjihrig commented Oct 26, 2017

Looking into this.

@cjihrig cjihrig mentioned this issue Oct 26, 2017
Closed
@cjihrig
Copy link

cjihrig commented Oct 26, 2017

Proposed fix in #22. It looks like the relevant changes in V8 are v8/v8@d953b2a

kisg pushed a commit to paul99/v8mips that referenced this issue Nov 7, 2017
@cjihrig
Update postmortem metadata jobs
14ddbc1 
This commit updates the jobs for generating postmortem
metadata. I96a8a7cdded6f7c37b6f1da659d63df9e3a5de2b moved
the Code class to a new file without updating the postmortem
jobs. This resulted in some constants used by Node.js to
disappear, leading to build failures on SmartOS.

See: nodejs/node-v8#21
Bug: 
Change-Id: Icf5f59fe464d933c4f5a3f622b08c01bc43c6a80
Reviewed-on: https://chromium-review.googlesource.com/741919
Commit-Queue: Yang Guo <[email protected]>
Reviewed-by: Yang Guo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#49168}
@targos
Copy link
Member Author

targos commented Nov 7, 2017

Fixed in https://chromium-review.googlesource.com/c/v8/v8/+/741919.

@targos targos closed this as completed Nov 7, 2017
@refack
Copy link

refack commented Nov 22, 2017

Well it's back with a new failed symbol V8DBG_CLASS_MAP__INSTANCE_ATTRIBUTES__INT:

dtrace: failed to compile script src/v8ustack.d: line 354: failed to resolve V8DBG_CLASS_MAP__INSTANCE_ATTRIBUTES__INT: Unknown variable name
make[2]: *** [node_dtrace_ustack.target.mk:26: /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos16-64/out/Release/obj.target/node/src/node_dtrace_ustack.o] Error 1

https://ci.nodejs.org/job/node-test-commit-smartos/13336/nodes=smartos16-64/console

@targos do you want to reopen this or open a new issue?

@targos targos reopened this Nov 22, 2017
@cjihrig
Copy link

cjihrig commented Nov 22, 2017

I'll look into what's broken this time :-)

@cjihrig cjihrig mentioned this issue Nov 22, 2017
Closed
@targos
Copy link
Member Author

targos commented Nov 24, 2017

Fixed in nodejs/node@7e26657

@targos targos closed this as completed Nov 24, 2017
@cjihrig cjihrig mentioned this issue Nov 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: update postmortem constant name cjihrig/node-v8
3 participants
@refack @targos @cjihrig