Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: collaborators list nits in README.md #12865

Closed
vsemozhetbyt opened this issue May 5, 2017 · 2 comments
Closed

meta: collaborators list nits in README.md #12865

vsemozhetbyt opened this issue May 5, 2017 · 2 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented May 5, 2017 •
edited
Loading

I've compared our user-created list with auto-generated one and found out some differences. FWIW:

  1. fishrock123 -> Fishrock123
  2. qard -> Qard
  3.   
    iWuzHere - Imran Iqbal                       <[email protected]> https://github.com/iWuzHere ->
imran-iq - Imran Iqbal (Previously iWuzHere)          ?             https://github.com/imran-iq

I am not sure if this should be addressed.

EDIT: Minor formatting update by @Trott so that `3.` displays correctly above.
@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label May 5, 2017
@Trott
Copy link
Member

Trott commented May 5, 2017

Number 4 is expected. Nothing to address there. It does seem like we ought to address 1, 2, and 3, though.

@vsemozhetbyt
Copy link
Contributor Author

I've deleted the last case as unnecessary.

@vsemozhetbyt vsemozhetbyt mentioned this issue May 5, 2017
Closed
2 tasks
anchnk pushed a commit to anchnk/node that referenced this issue May 19, 2017
@vsemozhetbyt
meta: fix nits in README.md collaborators list
29eacf1 
PR-URL: nodejs#12866
Fixes: nodejs#12865
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this issue Jun 20, 2017
@vsemozhetbyt @gibfahn
meta: fix nits in README.md collaborators list
332c9db 
PR-URL: #12866
Fixes: #12865
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Jul 11, 2017
@vsemozhetbyt @MylesBorins
meta: fix nits in README.md collaborators list
0cb5bd7 
PR-URL: #12866
Fixes: #12865
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Trott @vsemozhetbyt