-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert: RangeError: Maximum call stack size exceeded is still present #13314
Labels
Comments
rmdm
added a commit
to rmdm/node
that referenced
this issue
May 30, 2017
2 tasks
rmdm
added a commit
to rmdm/node
that referenced
this issue
Jun 1, 2017
This commit changes semantics of the memos cycles tracker. Before the change it was used to track all currently wisited nodes of an object tree, which is a bit shifted from its original intention of tracking cycles. The change brings intended semantics, by tracking only objects of the current branch of the object tree. Fixes: nodejs#13314
jasnell
pushed a commit
that referenced
this issue
Jun 5, 2017
Fixes: #13314 Refs: #6416 This commit changes semantics of the memos cycles tracker. Before the change it was used to track all currently wisited nodes of an object tree, which is a bit shifted from its original intention of tracking cycles. The change brings intended semantics, by tracking only objects of the current branch of the object tree. PR-URL: #13318 Fixes: #13314 Ref: #6416 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
var a = [];
a[0] = a;
JSON.stringify(a);
// Uncaught TypeError: Converting circular structure to JSON |
@wuliupo you can't stringify a circular structure. That's by spec and it is completely independent from the issue about the range error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
v6.9.1
andv8.0.0-pre
, but it seems like all versions are affected.The following code
ends up with
RangeError: Maximum call stack size exceeded
and it seems like changes for #6416 didn't fixed that error entirely.I'm going to provide the fix in a PR soon.
The text was updated successfully, but these errors were encountered: