Skip to content

document the test/common/dns module #15596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott opened this issue Sep 25, 2017 · 2 comments
Closed

document the test/common/dns module #15596

Trott opened this issue Sep 25, 2017 · 2 comments
Labels
doc Issues and PRs related to the documentations. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Sep 25, 2017

  • Version: v9.0.0-pre
  • Platform: n/a
  • Subsystem: test

The module in test/common/dns.js should be documented in test/common/README.md similar to the way the other modules in test/common are documented there.
@Trott Trott added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. labels Sep 25, 2017
@Supitto
Copy link

Supitto commented Sep 26, 2017

I'm doing it now :D

@cburwell cburwell mentioned this issue Oct 4, 2017
Closed
3 tasks
@cburwell
Copy link
Contributor

cburwell commented Oct 4, 2017 •
edited
Loading

Made a first pass at it.

PR: #15772

@Trott Trott closed this as completed in b9f90fd Oct 11, 2017
addaleax pushed a commit to addaleax/ayo that referenced this issue Oct 12, 2017
@cburwell @addaleax
doc: document the test/common/dns module
bcbef82 
Added requested documentation for the dns.js module. Also fixed a typo.

PR-URL: nodejs/node#15772
Fixes: nodejs/node#15596
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this issue Oct 18, 2017
@cburwell @targos
doc: document the test/common/dns module
698f358 
Added requested documentation for the dns.js module. Also fixed a typo.

PR-URL: #15772
Fixes: #15596
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Issue #15596 document test/common/dns
3 participants
@Trott @cburwell @Supitto