Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http.ClientRequest response object only emits close after abort? #17352

Closed
ronag opened this issue Nov 27, 2017 · 2 comments
Closed

http.ClientRequest response object only emits close after abort? #17352

ronag opened this issue Nov 27, 2017 · 2 comments
Labels
http Issues or PRs related to the http subsystem. question Issues that look for answers.

Comments

@ronag
Copy link
Member

ronag commented Nov 27, 2017

The response object from http.ClientRequest only seems to amit a close event if the request was aborted?
@mscdex mscdex added http Issues or PRs related to the http subsystem. question Issues that look for answers. labels Nov 27, 2017
@ronag
Copy link
Member Author

ronag commented Nov 27, 2017

Also, it seems to me that all errors are emitted on the request object and never on the response object. Is the 'error' listener even useful on the response object?

@ronag ronag mentioned this issue Nov 30, 2017
Closed
3 tasks
@dimonnwc3
Copy link

dimonnwc3 commented Dec 5, 2017 •
edited
Loading

I see that end emits from http.IncomingMessage(as a client response) in success case and when server closes connection as well (fail). Shouldn't be only close/aborted without end?

trivikr added a commit to trivikr/node that referenced this issue Apr 15, 2018
@trivikr
http: response should always emit close on finish
753ca2b 
Fixes: nodejs#17352
@trivikr trivikr mentioned this issue Apr 15, 2018
Closed
3 tasks
@ronag ronag mentioned this issue Apr 25, 2018
Closed
3 tasks
addaleax pushed a commit that referenced this issue May 14, 2018
@ronag @addaleax
http: fix client response close & aborted
4c6bfbd 
Fixes: #20102
Fixes: #20101
Fixes: #1735

- Response should always emit close.
- Response should always emit aborted if aborted.
- Response should always emit close after request has emitted close.

PR-URL: #20075
Fixes: #17352
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. question Issues that look for answers.
Projects
None yet
Milestone
No milestone
3 participants
@mscdex @ronag @dimonnwc3