New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add NO_COLOR to disable colors in assert doc #30484

Closed

shobhitchittora opened this issue Nov 14, 2019 · 1 comment

Labels

assert doc

Contributor

shobhitchittora commented Nov 14, 2019 •

edited

Loading

Currently the assert docs point to only NODE_DISABLE_COLORS env variable to disable tty colors. NO_COLOR does the same thing.

Going ahead and creating a small PR to add the variable there.

Version: v12.8.0
Platform: Darwin Kernel Version 18.7.0
Subsystem: doc

The text was updated successfully, but these errors were encountered:

shobhitchittora mentioned this issue

doc: adds NO_COLOR to assert doc page #30483

Closed

4 tasks

lpinca added assert doc labels

addaleax pushed a commit that referenced this issue


          doc: adds NO_COLOR to assert doc page

5bb4d85

Co-Authored-By: Vse Mozhet Byt <[email protected]>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>

BridgeAR pushed a commit that referenced this issue


          doc: adds NO_COLOR to assert doc page

7f664e4

Co-Authored-By: Vse Mozhet Byt <[email protected]>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>

targos pushed a commit that referenced this issue


          doc: adds NO_COLOR to assert doc page

8bb232f

Co-Authored-By: Vse Mozhet Byt <[email protected]>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>

Member

lpinca commented Dec 7, 2019

Fixed by #30483.

lpinca closed this as completed

MylesBorins pushed a commit that referenced this issue


          doc: adds NO_COLOR to assert doc page

ec5fe99

Co-Authored-By: Vse Mozhet Byt <[email protected]>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment