-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-fs-promises-write-optional-params does't check read bytes counts #46144
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
fs
Issues and PRs related to the fs subsystem / file system.
Comments
The same test behavior is for |
Thanks for catching this! The same also applies to
Both errors should be fixed by linked PR, but suggestions or alternative PR are always welcome. |
RafaelGSS
pushed a commit
that referenced
this issue
Jan 20, 2023
PR-URL: #46238 Fixes: #46144 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
juanarbol
pushed a commit
that referenced
this issue
Mar 3, 2023
PR-URL: #46238 Fixes: #46144 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
juanarbol
pushed a commit
that referenced
this issue
Mar 5, 2023
PR-URL: #46238 Fixes: #46144 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
fs
Issues and PRs related to the fs subsystem / file system.
Test
test-fs-promises-write-optional-params
Platform
Linux x64
Console output
No response
Build links
Additional information
There are several options in test-fs-promises-write-optional-params (at the file end) such as 'undefined', 'null', '{}' and so on. And for '{}' option we read 0 bytes in
testValid()
function and read buffer hasn't any changes after read. But all asserts intestValid()
functions are OK, because 2 errors:assert.ok(writeResult.bytesWritten >= readResult.bytesRead);
is ok because 3>0assert.deepStrictEqual(writeResult.buffer, readResult.buffer);
is also ok, because both buffers are the same and because read doesn't make any changes in buffer if 0 bytes was read.The text was updated successfully, but these errors were encountered: