-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
Add riscv64 to the list of supported architectures #49278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
PR-URL: nodejs#49278 Signed-off-by: Stewart X Addison <[email protected]>
Well spotted - thanks. |
Any idea when the RISC-V binaries will be promoted from the unofficial section to first class citizens? |
I don't think anyone's really been pushing for it but as long as we have someone willing to stand up to fix any issues there isn't too much blocking it. To be honest the main reason I haven't personally pushed it forward is because we haven't fixed the fact it's building openssl without assembler optimisation. I'm fairly certain it's not a hard fix but I haven't been able to justify spending time on it (yet) :-) We'd also need to check if there are any outstanding issues with the tests (other than any related to the openssl options) I do run a Node web server at home on a MangoPi D1 though and it seems to have been reliable enough though... |
I tried a build via the nvm scripts, and I noticed that the openssl selected the wrong architecture. I'll try to take a look at this in the near future, but I currently have only a QEMU machine to experiment with. Can you point me to the scripts used to build the unofficial binaries? |
https://github.com/nodejs/unofficial-builds/tree/main/recipes/riscv64 |
PR-URL: #49284 Signed-off-by: Stewart X Addison <[email protected]> Fixes: #49278 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #49284 Signed-off-by: Stewart X Addison <[email protected]> Fixes: #49278 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#49284 Signed-off-by: Stewart X Addison <[email protected]> Fixes: nodejs#49278 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Affected URL(s)
https://nodejs.org/dist/latest-v20.x/docs/api/os.html#osarch
Description of the problem
The
node.git/doc/api/os.md
file currently reads:I suggest to change it to:
The same for
node.git/doc/api/process.md
.The text was updated successfully, but these errors were encountered: