Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: unpin eslint-plugin-markdown #14045

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 3, 2017

First commit:

tools: remove pinning of eslint-plugin-markdown

An issue affecting Node.js source has been fixed in
eslint-plugin-markdown so we don't need to pin it to beta-4 anymore.

Refs: https://github.com/eslint/eslint-plugin-markdown/issues/69

Second commit:

tools: update eslint-plugin-markdown

Update eslint-plugin-markdown to beta-7. Other dependencies were updated
as well by the `update-eslint.sh` script.

/cc @vsemozhetbyt

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@Trott Trott added the tools Issues and PRs related to the tools directory. label Jul 3, 2017
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 3, 2017
@Trott
Copy link
Member Author

Trott commented Jul 3, 2017

Hmmm, this seems to have only bumped it to beta-6 (because beta-7 hasn't been published to npm yet) but it doesn't seem to trigger any errors so ¯\(ツ)

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jul 3, 2017

@Trott I was on it and had the same issue, but the npm install --no-bin-links --production [email protected] did the thing.

It seems we should have issues with doc linting after 1.0.0-beta.7 due to new skip comment format and no fall-through.

@Trott
Copy link
Member Author

Trott commented Jul 3, 2017

@Trott I was on it and had the same issue, but the npm install --no-bin-links --production [email protected] did the thing.

It seems we should have the issues with doc linting after 1.0.0-beta.7 due to new comment skip format and no fall-through.

Cool. Want me to close this and you can handle it whenever/however is best?

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jul 3, 2017

FWIW, should tools/package-lock.json be auto updated, manually updated or ignored?

https://github.com/Trott/io.js/blob/unpin-eslint-plugin-markdown/tools/package-lock.json#L196-L199

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jul 3, 2017

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jul 3, 2017

I can try to handle this, but I cannot run update-eslint.sh on Windows. Would the npm install --no-bin-links --production [email protected] suffice for update commit?

@Trott
Copy link
Member Author

Trott commented Jul 3, 2017

Would the npm install --no-bin-links --production [email protected] suffice for update commit?

That along with two other steps:

  • npm install -g dmn && dmn -f clean to remove a small number of unnecessary files.

  • And update tools/update-eslint.sh to change @1.0.0-beta.4 to @next.

Trott added 2 commits July 2, 2017 18:08
An issue affecting Node.js source has been fixed in
eslint-plugin-markdown so we don't need to pin it to beta-4 anymore.

Refs: eslint/markdown#69
Update eslint-plugin-markdown to beta-7. Other dependencies were updated
as well by the `update-eslint.sh` script.
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jul 3, 2017

@Trott
PTAL: #14047

  1. I've used the message of your first commit.
  2. I've manually updated eslint-plugin-markdown part of tools/package-lock.json according to tools/eslint/package-lock.json, not sure if any other changes are required in this file.
  3. Docs are fixed in the commit 3.

@Trott
Copy link
Member Author

Trott commented Jul 3, 2017

Closing in favor of #14047

@Trott Trott closed this Jul 3, 2017
@Trott Trott deleted the unpin-eslint-plugin-markdown branch October 10, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants