-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: unpin eslint-plugin-markdown #14045
Conversation
Hmmm, this seems to have only bumped it to beta-6 (because beta-7 hasn't been published to npm yet) but it doesn't seem to trigger any errors so ¯\(ツ)/¯ |
@Trott I was on it and had the same issue, but the It seems we should have issues with doc linting after 1.0.0-beta.7 due to new skip comment format and no fall-through. |
Cool. Want me to close this and you can handle it whenever/however is best? |
FWIW, should |
It seems the |
I can try to handle this, but I cannot run |
That along with two other steps:
|
An issue affecting Node.js source has been fixed in eslint-plugin-markdown so we don't need to pin it to beta-4 anymore. Refs: eslint/markdown#69
Update eslint-plugin-markdown to beta-7. Other dependencies were updated as well by the `update-eslint.sh` script.
d6078ef
to
0369b1d
Compare
Closing in favor of #14047 |
First commit:
Second commit:
/cc @vsemozhetbyt
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
tools