[v6.x backport] tools: update ESLint to v4.0.0 #14340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the "can we lint?" check in Makefile and vcbuild.bat depend on bin/eslint.js rather than lib/eslint.js. In ESLint 4.0.0, lib/eslint.js is not present. The lint rules call bin/eslint.js so check for that instead. PR-URL: nodejs#13645 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot
added
build
targos
reviewed
Jul 18, 2017
| @@ -1,4 +1,25 @@ | |||
| /* eslint-disable indent, no-tabs */ | |||
| // Copyright Joyent, Inc. and other Node contributors. | |||
There was a problem hiding this comment.
is that change supposed to be here?
There was a problem hiding this comment.
The copyright is in the file in master, so I assumed so...
There was a problem hiding this comment.
Oh, wait, I see, the copyright has not been restored to the v6.x-staging branch, at least not yet. OK, I'll remove it.
targos
reviewed
Jul 18, 2017
.eslintrc.yaml
Outdated
| @@ -117,18 +124,19 @@ rules: | |||
| }, { | |||
| selector: "ThrowStatement > CallExpression[callee.name=/Error$/]", | |||
| message: "Use new keyword when throwing an Error." | |||
| }, { | |||
| selector: "CallExpression[callee.object.name='assert'][callee.property.name='fail'][arguments.length=1]", | |||
There was a problem hiding this comment.
This rule should not be removed. It was in a semver-major change: #12293
There was a problem hiding this comment.
I took the rule out because it was part of a merge conflict when cherry-picking, and in those cases, I err on the side of more lenient linting in previous releases. I think you're right, and I should restore it.
There was a problem hiding this comment.
OK, I restored the rule. Thanks!
targos
approved these changes
Jul 18, 2017
Update ESLint and configuration to version 4.0.0. PR-URL: nodejs#13645 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
refack
approved these changes
Jul 18, 2017
|
landed in fcb27fa...4ffe804 |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 18, 2017
Make the "can we lint?" check in Makefile and vcbuild.bat depend on bin/eslint.js rather than lib/eslint.js. In ESLint 4.0.0, lib/eslint.js is not present. The lint rules call bin/eslint.js so check for that instead. Backport-PR-URL: #14340 PR-URL: #13645 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 18, 2017
Update ESLint and configuration to version 4.0.0. Backport-PR-URL: #14340 PR-URL: #13645 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ESLint and configuration to version 4.0.0.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools