Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test,doc: make module name match gyp target name #15209

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmark/misc/function_call/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ extern "C" void init (Local<Object> target) {
NODE_SET_METHOD(target, "hello", Hello);
}

NODE_MODULE(binding, init)
NODE_MODULE(NODE_GYP_MODULE_NAME, init)
20 changes: 10 additions & 10 deletions doc/api/addons.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ void init(Local<Object> exports) {
NODE_SET_METHOD(exports, "hello", Method);
}

NODE_MODULE(addon, init)
NODE_MODULE(NODE_GYP_MODULE_NAME, init)

} // namespace demo
```
Expand All @@ -84,7 +84,7 @@ the pattern:

```cpp
void Initialize(Local<Object> exports);
NODE_MODULE(module_name, Initialize)
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
```

There is no semi-colon after `NODE_MODULE` as it's not a function (see
Expand Down Expand Up @@ -330,7 +330,7 @@ void Init(Local<Object> exports) {
NODE_SET_METHOD(exports, "add", Add);
}

NODE_MODULE(addon, Init)
NODE_MODULE(NODE_GYP_MODULE_NAME, Init)

} // namespace demo
```
Expand Down Expand Up @@ -378,7 +378,7 @@ void Init(Local<Object> exports, Local<Object> module) {
NODE_SET_METHOD(module, "exports", RunCallback);
}

NODE_MODULE(addon, Init)
NODE_MODULE(NODE_GYP_MODULE_NAME, Init)

} // namespace demo
```
Expand Down Expand Up @@ -434,7 +434,7 @@ void Init(Local<Object> exports, Local<Object> module) {
NODE_SET_METHOD(module, "exports", CreateObject);
}

NODE_MODULE(addon, Init)
NODE_MODULE(NODE_GYP_MODULE_NAME, Init)

} // namespace demo
```
Expand Down Expand Up @@ -493,7 +493,7 @@ void Init(Local<Object> exports, Local<Object> module) {
NODE_SET_METHOD(module, "exports", CreateFunction);
}

NODE_MODULE(addon, Init)
NODE_MODULE(NODE_GYP_MODULE_NAME, Init)

} // namespace demo
```
Expand Down Expand Up @@ -529,7 +529,7 @@ void InitAll(Local<Object> exports) {
MyObject::Init(exports);
}

NODE_MODULE(addon, InitAll)
NODE_MODULE(NODE_GYP_MODULE_NAME, InitAll)

} // namespace demo
```
Expand Down Expand Up @@ -713,7 +713,7 @@ void InitAll(Local<Object> exports, Local<Object> module) {
NODE_SET_METHOD(module, "exports", CreateObject);
}

NODE_MODULE(addon, InitAll)
NODE_MODULE(NODE_GYP_MODULE_NAME, InitAll)

} // namespace demo
```
Expand Down Expand Up @@ -926,7 +926,7 @@ void InitAll(Local<Object> exports) {
NODE_SET_METHOD(exports, "add", Add);
}

NODE_MODULE(addon, InitAll)
NODE_MODULE(NODE_GYP_MODULE_NAME, InitAll)

} // namespace demo
```
Expand Down Expand Up @@ -1117,7 +1117,7 @@ void init(Local<Object> exports) {
AtExit(sanity_check);
}

NODE_MODULE(addon, init)
NODE_MODULE(NODE_GYP_MODULE_NAME, init)

} // namespace demo
```
Expand Down
4 changes: 2 additions & 2 deletions doc/api/n-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -877,7 +877,7 @@ except that instead of using the `NODE_MODULE` macro the following
is used:

```C
NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
```

The next difference is the signature for the `Init` method. For a N-API
Expand Down Expand Up @@ -2874,7 +2874,7 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
if (status != napi_ok) return;
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
```

Given the above code, the add-on can be used from JavaScript as follows:
Expand Down
2 changes: 1 addition & 1 deletion test/addons-napi/1_hello_world/binding.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
NAPI_CALL_RETURN_VOID(env, napi_define_properties(env, exports, 1, &desc));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/2_function_arguments/binding.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
NAPI_CALL_RETURN_VOID(env, napi_define_properties(env, exports, 1, &desc));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/3_callbacks/binding.c
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
NAPI_CALL_RETURN_VOID(env, napi_define_properties(env, exports, 2, desc));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/4_object_factory/binding.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
NAPI_CALL_RETURN_VOID(env, napi_define_properties(env, module, 1, &desc));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/5_function_factory/binding.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
NAPI_CALL_RETURN_VOID(env, napi_define_properties(env, module, 1, &desc));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/6_object_wrap/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
MyObject::Init(env, exports);
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/7_factory_wrap/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
NAPI_CALL_RETURN_VOID(env, napi_define_properties(env, module, 1, &desc));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/8_passing_wrapped/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
napi_define_properties(env, exports, sizeof(desc) / sizeof(*desc), desc));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_array/test_array.c
Original file line number Diff line number Diff line change
Expand Up @@ -182,4 +182,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(descriptors) / sizeof(*descriptors), descriptors));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_async/test_async.cc
Original file line number Diff line number Diff line change
Expand Up @@ -170,4 +170,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(properties) / sizeof(*properties), properties));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_buffer/test_buffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -141,4 +141,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(methods) / sizeof(methods[0]), methods));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_constructor/test_constructor.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
napi_create_reference(env, cons, 1, &constructor_));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_conversions/test_conversions.c
Original file line number Diff line number Diff line change
Expand Up @@ -148,4 +148,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(descriptors) / sizeof(*descriptors), descriptors));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_dataview/test_dataview.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(descriptors) / sizeof(*descriptors), descriptors));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_env_sharing/compare_env.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* context) {
NAPI_CALL_RETURN_VOID(env, napi_define_properties(env, module, 1, &prop));
}

NAPI_MODULE(compare_env, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_env_sharing/store_env.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* context) {
napi_set_named_property(env, module, "exports", external));
}

NAPI_MODULE(store_env, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_error/test_error.cc
Original file line number Diff line number Diff line change
Expand Up @@ -141,4 +141,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(descriptors) / sizeof(*descriptors), descriptors));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_exception/test_exception.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(descriptors) / sizeof(*descriptors), descriptors));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_fatal/test_fatal.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(properties) / sizeof(*properties), properties));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_function/test_function.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
NAPI_CALL_RETURN_VOID(env, napi_set_named_property(env, exports, "Test", fn));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_general/test_general.c
Original file line number Diff line number Diff line change
Expand Up @@ -239,4 +239,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(descriptors) / sizeof(*descriptors), descriptors));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_handle_scope/test_handle_scope.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(properties) / sizeof(*properties), properties));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_make_callback/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {

} // namespace

NAPI_MODULE(binding, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_make_callback_recurse/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {

} // namespace

NAPI_MODULE(binding, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_number/test_number.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(descriptors) / sizeof(*descriptors), descriptors));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_object/test_object.c
Original file line number Diff line number Diff line change
Expand Up @@ -236,4 +236,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(descriptors) / sizeof(*descriptors), descriptors));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_promise/test_promise.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(descriptors) / sizeof(*descriptors), descriptors));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_properties/test_properties.c
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(properties) / sizeof(*properties), properties));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_reference/test_reference.c
Original file line number Diff line number Diff line change
Expand Up @@ -150,4 +150,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(descriptors) / sizeof(*descriptors), descriptors));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_string/test_string.c
Original file line number Diff line number Diff line change
Expand Up @@ -217,4 +217,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(properties) / sizeof(*properties), properties));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_symbol/test_symbol.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(properties) / sizeof(*properties), properties));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_typedarray/test_typedarray.c
Original file line number Diff line number Diff line change
Expand Up @@ -153,4 +153,4 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
env, exports, sizeof(descriptors) / sizeof(*descriptors), descriptors));
}

NAPI_MODULE(addon, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons/async-hello-world/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,4 @@ void init(v8::Local<v8::Object> exports, v8::Local<v8::Object> module) {
NODE_SET_METHOD(exports, "runMakeCallback", Method<true>);
}

NODE_MODULE(binding, init)
NODE_MODULE(NODE_GYP_MODULE_NAME, init)
2 changes: 1 addition & 1 deletion test/addons/async-hooks-id/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ void Initialize(Local<Object> exports) {

} // namespace

NODE_MODULE(binding, Initialize)
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
2 changes: 1 addition & 1 deletion test/addons/async-hooks-promise/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ inline void Initialize(v8::Local<v8::Object> binding) {
NODE_SET_METHOD(binding, "getPromiseField", GetPromiseField);
}

NODE_MODULE(binding, Initialize)
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)

} // anonymous namespace
2 changes: 1 addition & 1 deletion test/addons/async-resource/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -111,4 +111,4 @@ void Initialize(Local<Object> exports) {

} // namespace

NODE_MODULE(binding, Initialize)
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
2 changes: 1 addition & 1 deletion test/addons/at-exit/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ void init(Local<Object> exports) {
atexit(sanity_check);
}

NODE_MODULE(binding, init)
NODE_MODULE(NODE_GYP_MODULE_NAME, init)
2 changes: 1 addition & 1 deletion test/addons/buffer-free-callback/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "check", Check);
}

NODE_MODULE(binding, init)
NODE_MODULE(NODE_GYP_MODULE_NAME, init)
2 changes: 1 addition & 1 deletion test/addons/errno-exception/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "errno", Method);
}

NODE_MODULE(binding, init)
NODE_MODULE(NODE_GYP_MODULE_NAME, init)
2 changes: 1 addition & 1 deletion test/addons/heap-profiler/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ inline void Initialize(v8::Local<v8::Object> binding) {
v8::FunctionTemplate::New(isolate, Test)->GetFunction());
}

NODE_MODULE(test, Initialize)
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)

} // anonymous namespace
2 changes: 1 addition & 1 deletion test/addons/hello-world-function-export/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ void init(v8::Local<v8::Object> exports, v8::Local<v8::Object> module) {
NODE_SET_METHOD(module, "exports", Method);
}

NODE_MODULE(binding, init)
NODE_MODULE(NODE_GYP_MODULE_NAME, init)
2 changes: 1 addition & 1 deletion test/addons/hello-world/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "hello", Method);
}

NODE_MODULE(binding, init)
NODE_MODULE(NODE_GYP_MODULE_NAME, init)
2 changes: 1 addition & 1 deletion test/addons/load-long-path/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "hello", Method);
}

NODE_MODULE(binding, init)
NODE_MODULE(NODE_GYP_MODULE_NAME, init)
2 changes: 1 addition & 1 deletion test/addons/make-callback-recurse/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ void Initialize(Local<Object> exports) {

} // namespace

NODE_MODULE(binding, Initialize)
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
2 changes: 1 addition & 1 deletion test/addons/make-callback/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ void Initialize(v8::Local<v8::Object> exports) {

} // namespace

NODE_MODULE(binding, Initialize)
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
2 changes: 1 addition & 1 deletion test/addons/new-target/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ inline void Initialize(v8::Local<v8::Object> binding) {
v8::FunctionTemplate::New(isolate, NewClass)->GetFunction());
}

NODE_MODULE(binding, Initialize)
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)

} // anonymous namespace
Loading