Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport to v6] test: begin normalizing fixtures use #16265

Closed
wants to merge 34 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
b8ab430
build: call setlocal in vcbuild.bat
danbev Oct 2, 2017
3991953
doc: fix incorrect vm.createContext usage
tshemsedinov Oct 7, 2017
c405f95
src: fix ^ in stack trace with vm's columnOffset
TimothyGu Oct 4, 2017
c81b425
test: remove messages in assert.strictEqual
Saeed-Navarik Oct 6, 2017
6d49154
doc: update style guide for markdown extension
Trott Oct 5, 2017
d0157b7
test: alter assert.strictEqual to default message
gishmel Oct 6, 2017
0c0717c
test: replacing assert message with template
Oct 6, 2017
bf1bf28
test: improve assert messages
ericljpemberton Oct 6, 2017
d3544c1
doc: add clearer setup description
craftninja Oct 6, 2017
b43fed4
test: replace literal with template string
brantphoto Oct 6, 2017
97cf4f1
tools: use template literals
sarahmeyer Oct 6, 2017
a686f9c
test: removed string from assert message arg
dpaulino Oct 6, 2017
b93842a
test: changes to use template literal
joanne-jjb Oct 6, 2017
3371ee8
test: remove literal error messages
fyesoft Oct 6, 2017
c53ed73
test: changed buffer-zero output
garlicbrie Oct 6, 2017
ad25c28
test: display better error message for assertion
SgtPooki Oct 6, 2017
44f3efc
test: replaced literals in errors with templates
domrein Oct 6, 2017
d179660
doc: fix macosx-firewall suggestion BUILDING
Suraiya-Hameed Oct 6, 2017
46f4597
test: improve an error message
pomerantsev Oct 6, 2017
cd8d15e
test: remove message from asserts
justin0022 Oct 6, 2017
f469169
test: improve asset msg in test
genewoo Oct 6, 2017
06519b8
test: replace string concatenation with template
robtpaton Oct 6, 2017
79667a8
test: add NODE_UNIQUE_ID value to err message
danielelisi Oct 6, 2017
734642d
test: replace error msg w/ template literal
sashimii Oct 6, 2017
51db86d
test: assert.strictEqual using template literals
jmcgui05 Oct 9, 2017
c00f719
test: updated error message
craftninja Oct 6, 2017
88e6ecc
test: cleanup test-buffer-sharedarraybuffer
RafLeszczynski Oct 6, 2017
ac7db84
test: include expected result in error messages
keywordnew Oct 6, 2017
f54608e
tools: replace concat with template literals
Oct 6, 2017
f19096f
doc: mention collaboration summit in onboarding.md
joyeecheung Oct 8, 2017
26b8c8d
doc: add kfarnung to collaborators
kfarnung Oct 9, 2017
3e5e8cb
test: clarify assert messages in crypto tests
cpandrews8 Oct 6, 2017
3996e8a
test: remove assert message
johenry Oct 6, 2017
a721d23
test: begin normalizing fixtures use
jasnell Jul 17, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: changed buffer-zero output
Added interpolated strings to display the error value

PR-URL: #15926
Reviewed-By: Ruben Bridgewater <[email protected]>
garlicbrie authored and MylesBorins committed Oct 17, 2017

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
commit c53ed738915864a1e621472ea709f3f09d6f20f1
2 changes: 1 addition & 1 deletion test/parallel/test-buffer-zero-fill-reset.js
Original file line number Diff line number Diff line change
@@ -15,5 +15,5 @@ function testUint8Array(ui) {
for (let i = 0; i < 100; i++) {
Buffer.alloc(0);
const ui = new Uint8Array(65);
assert.ok(testUint8Array(ui), 'Uint8Array is not zero-filled');
assert.ok(testUint8Array(ui), `Uint8Array is not zero-filled: ${ui}`);
}