Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make header file self-contained #16518

Closed
wants to merge 1 commit into from
Closed

src: make header file self-contained #16518

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Make node_crypto_clienthello-inl.h self-contained.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Just noticed that the includes can't be sorted when tweaking clang-format.

@joyeecheung
src: make header file self-contained
289a364 
Make node_crypto_clienthello-inl.h self-contained.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Oct 26, 2017
@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/11001/

@addaleax
Copy link
Member

Landed in 75f1087

@addaleax addaleax closed this Oct 26, 2017
addaleax pushed a commit that referenced this pull request Oct 26, 2017
@joyeecheung @addaleax
src: make header file self-contained
75f1087 
Make node_crypto_clienthello-inl.h self-contained.

PR-URL: #16518
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@joyeecheung @addaleax
src: make header file self-contained
51502ff 
Make node_crypto_clienthello-inl.h self-contained.

PR-URL: nodejs/node#16518
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
@joyeecheung joyeecheung mentioned this pull request Oct 30, 2017
Closed
4 tasks
joyeecheung added a commit to joyeecheung/node that referenced this pull request Oct 30, 2017
@joyeecheung
src: make header file self-contained
b1e4d3c 
Make node_crypto_clienthello-inl.h self-contained.

PR-URL: nodejs#16518
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@joyeecheung joyeecheung mentioned this pull request Oct 30, 2017
Closed
4 tasks
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@joyeecheung @gibfahn
src: make header file self-contained
2fe4fcd 
Make node_crypto_clienthello-inl.h self-contained.

PR-URL: #16518
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@joyeecheung @gibfahn
src: make header file self-contained
ef6597f 
Make node_crypto_clienthello-inl.h self-contained.

PR-URL: #16518
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@joyeecheung @gibfahn
src: make header file self-contained
ee40368 
Make node_crypto_clienthello-inl.h self-contained.

PR-URL: #16518
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@gibfahn gibfahn mentioned this pull request Oct 31, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@joyeecheung @MylesBorins
src: make header file self-contained
13d42d8 
Make node_crypto_clienthello-inl.h self-contained.

Backport-PR-URL: #16610
PR-URL: #16518
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@joyeecheung @MylesBorins
src: make header file self-contained
13eb5d9 
Make node_crypto_clienthello-inl.h self-contained.

Backport-PR-URL: #16610
PR-URL: #16518
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@joyeecheung @MylesBorins
src: make header file self-contained
a4688b0 
Make node_crypto_clienthello-inl.h self-contained.

Backport-PR-URL: #16610
PR-URL: #16518
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@joyeecheung @addaleax
src: make header file self-contained
3c3e74b 
Make node_crypto_clienthello-inl.h self-contained.

PR-URL: nodejs/node#16518
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joyeecheung @addaleax @bnoordhuis @jasnell @cjihrig @MylesBorins @nodejs-github-bot