Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: warn users about non-ASCII paths on build #16735

Closed
wants to merge 1 commit into from
+2 −1
Closed

docs: warn users about non-ASCII paths on build #16735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
docs: warn users about non-ASCII paths on build 
The build breaks if there's a non-ASCII character on the path to the building
directory.

Ref: #16278
Ref: #14336
Matheus Marchini authored and Matheus Marchini committed Dec 12, 2017
commit 0e90f1afc6b6b3780c0186d25d47be9a11a05d91
3 changes: 2 additions & 1 deletion BUILDING.md
View file
Original file line number Diff line number Diff line change
@@ -215,7 +215,8 @@ Prerequisites:
* **Optional** (to build the MSI): the [WiX Toolset v3.11](http://wixtoolset.org/releases/)
and the [Wix Toolset Visual Studio 2017 Extension](https://marketplace.visualstudio.com/items?itemName=RobMensching.WixToolsetVisualStudio2017Extension).

If the path to your build directory contains a space, the build will likely fail.
If the path to your build directory contains a space or a non-ASCII character, the
build will likely fail.

```console
> .\vcbuild