Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Expose the public key of a certificate & cert sha256 #17690

Closed
wants to merge 4 commits into from
+164 −21
Closed

crypto: Expose the public key of a certificate & cert sha256 #17690

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba19b7b
crypto: add cert.fingerprint256 as SHA256 fingerprint
bjori Dec 14, 2017
77b3abf
crypto: add cert.pubkey containing the raw pubkey of certificate
Hannes-Magnusson-CK Feb 7, 2018
2987c0e
crypto: provide full cert details to checkServerIdentity
Hannes-Magnusson-CK Dec 14, 2017
1be548b
crypto: add docs & tests for cert.pubkey & cert.fingerprint256
Hannes-Magnusson-CK Feb 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
crypto: provide full cert details to checkServerIdentity
@Hannes-Magnusson-CK
Hannes-Magnusson-CK committed Feb 14, 2018
commit 2987c0ebc4e932246096a15c71509ffa98db9737
2 changes: 1 addition & 1 deletion lib/_tls_wrap.js
View file
Original file line number Diff line number Diff line change
@@ -1055,7 +1055,7 @@ function onConnectSecure() {
options.host ||
(options.socket && options.socket._host) ||
'localhost';
const cert = this.getPeerCertificate();
const cert = this.getPeerCertificate(true);
verifyError = options.checkServerIdentity(hostname, cert);
}