Skip to content

v6.12.3 proposal #17776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 116 commits into from
Jan 2, 2018
Merged
Changes from 1 commit
Commits
Show all changes
116 commits
Select commit Hold shift + click to select a range
d176073
tty: refactor exports
cjihrig Nov 12, 2017
c18a450
test: add coverage to tty module
cjihrig Nov 12, 2017
92f41e5
build: allow enabling the --trace-maps flag in V8
evanlucas Jul 1, 2017
93ca2f7
meta: allow vague objections to be dismissed
jasnell Sep 6, 2017
9804e7f
deps: V8: cherry-pick 9622696 from upstream
ofrobots Dec 12, 2017
b287b9e
deps: V8: cherry-pick e8e9c07 from upstream
ofrobots Dec 12, 2017
0f94bb9
doc: add hashseed to collaborators
hashseed Nov 7, 2017
a12e168
path: remove obsolete comment
Trott Nov 14, 2017
92daa2d
test: make REPL test pass in coverage mode
addaleax Nov 16, 2017
5cd89c7
doc,win: clarify WSL support
joaocgreis Nov 14, 2017
e03645d
doc: add Support section in README
Trott Oct 26, 2017
d44adf1
doc: delete unused definition in README.md
vsemozhetbyt Nov 17, 2017
dcf7646
tools: fail tests if malformed status file
Trott Nov 3, 2017
ccdf4b2
doc: reorganize collaborator guide
joyeecheung Nov 15, 2017
fe21886
test: use arrow functions instead of bind
tniessen Nov 16, 2017
b16e6d2
doc: explicitly document highWaterMark option
eps1lon Nov 15, 2017
8cae573
doc: add note about using cluster without networking
pimlie Nov 15, 2017
39cd0a8
test: utilize common.mustCall() on child exit
sreepurnajasti Nov 13, 2017
f11acca
src: fix size of CounterSet
wip0 Nov 13, 2017
3d22e81
build: minor corrections to configure descriptions
danbev Nov 16, 2017
b064c73
doc: remove IRC node-dev link from README
Trott Nov 17, 2017
d8f6667
doc: merge Working Groups with Contributing to Node.js in README
Trott Nov 17, 2017
1815ca5
doc: add Contributing to Node.js to the README ToC
Trott Nov 17, 2017
ca76c33
doc: normalize ToC indentation with heading levels in README
Trott Nov 17, 2017
466e94a
tools: avoid using process.cwd in tools/lint-js
tniessen Nov 18, 2017
e232e21
doc: update AUTHORS list
targos Oct 28, 2017
4eb1b58
test: remove unused variable
gflandre Nov 21, 2017
43e4669
test: remove unused parameter
franher Nov 21, 2017
84a8861
src: remove unprofessional slang in assertions
aqrln Nov 21, 2017
fd36b27
test: remove unused parameter in test-next-tick-error-spin.js
FKSI Nov 21, 2017
5d488ee
test: wrap callback in common.mustCall
suman-mitra Nov 21, 2017
d4e9a25
doc: add guybedford to collaborators
guybedford Nov 21, 2017
80c6384
doc: update release table in V8 guide
ofrobots Nov 19, 2017
3f39e47
doc: update mgol in AUTHORS.txt, add to .mailmap
mgol Nov 22, 2017
0963c75
test: clean up inappropriate language
devsnek Nov 21, 2017
e7ca894
test: use common.crashOnUnhandledRejection
madeinfree Nov 22, 2017
289ebb1
test: use crashOnUnhandledRejection
purepennons Nov 22, 2017
353e66f
test: use arrow function instead of bind
lance Nov 21, 2017
d4a5499
test: use common.crashOnUnhandledRejection
esbb48 Nov 22, 2017
6620e76
test: use crashOnUnhandledRejection
roth1002 Nov 22, 2017
71671df
test: fix linting error
jasnell Nov 22, 2017
5f522a1
doc: use better terminology for build machines
addaleax Nov 19, 2017
7c57ab7
test: dont need to remove nonexistent directory
ah-yu Nov 18, 2017
7cbdeef
test: remove unlink function which is needless
ah-yu Nov 20, 2017
89f1b6c
test: add common.crashOnHandleRejection
Jackyen Nov 22, 2017
699659e
test: use common.crashOnUnhandledRejection()
sorarize Nov 22, 2017
797e33b
test: use common.crashOnUnhandledRejection
Nov 22, 2017
a0bd1c0
doc: add SharedArrayBuffer to Buffer documentation
ThomasdenH Sep 20, 2017
d692f45
doc: update http URLs to https in CONTRIBUTING.md
him2him2 Nov 22, 2017
23f21a6
doc: update http URLs to https in GOVERNANCE.md
him2him2 Nov 22, 2017
ab91fe1
doc: update http URLs to https in README.md
him2him2 Nov 22, 2017
b13dab8
doc: add maclover7 to collaborators
maclover7 Nov 24, 2017
46dc241
doc: fix typo in api doc of url.format(urlObject)
cxn-pkovacs Nov 25, 2017
b63f51a
test: use common.crashOnUnhandledRejection
sj82516 Nov 23, 2017
75ad37c
test: use common.crashOnUnhandledRejection
Kcin1993 Nov 22, 2017
bdbcdeb
test: add test of stream Transform
kt3k Nov 26, 2017
8098a6e
test: use Number.isNaN()
fossamagna Nov 26, 2017
c0c3666
test: use arrow function
koooge Nov 26, 2017
0ef4f78
test: replace function with arrow function
karszawa Nov 26, 2017
b2236a3
doc: replace function with arrow function in vm.md
narirou Nov 26, 2017
c519287
doc: replace string with template string
Leko Nov 26, 2017
1cd4076
test: replace function with arrow function
Nov 26, 2017
32ebcf7
test: make use of Number.isNaN to test-readfloat.js
hiromoon Nov 26, 2017
35cc1b3
test: fix isNAN->Number.isNAN
ykyz Nov 26, 2017
9ba35e8
build: remove empty VCLibrarianTool entry
danbev Nov 20, 2017
6792998
src: make base64.h self-contained
danbev Nov 21, 2017
3eab248
doc: Add link for ECMAScript 2015
Nov 26, 2017
956198f
test: Update test-http-client-agent to use countdown timer
daxlab Nov 26, 2017
f3c1158
test: Update test-http-parser-free to use countdown timer
daxlab Nov 26, 2017
3a0cb8f
test: refactored http test to use countdown
mithunsasidharan Nov 22, 2017
4f3a165
test: replace function with ES6 arrow function
kjunichi Nov 26, 2017
90ee2ee
doc: clarify fast-track of reversions
refack Nov 26, 2017
ad9a857
build: fix test-v8 target
targos Nov 23, 2017
35316dc
doc: add guide to maintaining npm
MylesBorins Oct 27, 2017
afd4d9e
tools: add Boxstarter script
bzoz Nov 14, 2017
0fa2f39
doc: improve checkServerIdentity docs
Hannes-Magnusson-CK Nov 21, 2017
8908cd6
test: refactored test-http-response-splitting to use countdown
mithunsasidharan Nov 27, 2017
3ee4c1e
test: update test/parallel/test-http-pipe-fs.js to use countdown
chungngoops Nov 27, 2017
42454a5
test: refactored test-http-allow-req-after-204-res to countdown
mithunsasidharan Nov 28, 2017
8f997c0
test: update test-http-status-reason-invalid-chars to use countdown
mithunsasidharan Nov 27, 2017
660e6de
test: update test-http-upgrade-client to use countdown
mithunsasidharan Nov 27, 2017
47e5fd9
test: update test-http-response-multiheaders to use countdown
Dec 3, 2017
8fc1969
test: use Countdown in http test
mithunsasidharan Dec 3, 2017
f9adf51
test: use common.mustCall in test-http-malformed-request
mithunsasidharan Dec 3, 2017
d1d547d
test: update test-http-request-dont-override-options to use common.mu…
mithunsasidharan Dec 3, 2017
4d4337d
doc: use colon consistently in assert.md
Trott Dec 5, 2017
e8368a1
doc: improve punctuation in fs.open() text
Trott Dec 5, 2017
8ca12e2
doc: standardize preposition usage in fs.md
Trott Dec 5, 2017
c24fafa
doc: edit module introduction
Trott Dec 5, 2017
017492e
build: add serial commas to messages in configure script
Trott Dec 5, 2017
92d2c9a
doc: update AUTHORS list
targos Dec 4, 2017
3cf8f98
test: add common.crashOnUnhandledRejection()
IHsuan Nov 22, 2017
b563908
crypto: use SetNull instead of Set
danbev Dec 6, 2017
a15da3b
doc: fix common typo involving one-time listeners
Trott Dec 6, 2017
a44f085
doc: fix typo in repl.md
Trott Dec 6, 2017
6e7ace2
test: replace fs.accessSync with fs.existsSync
Leko Dec 4, 2017
ee52ce9
doc: mention node-test-pull-request-lite job
maclover7 Dec 7, 2017
d4d3f50
test: Use common.mustCall in http test
sreepurnajasti Dec 6, 2017
68dabce
test: use Countdown in test-http-set-cookies
shilomagen Dec 6, 2017
e9cacee
test: use Countdown in http-response-statuscode
daxlab Nov 26, 2017
013ef22
doc: improve readability of COLLABORATOR_GUIDE.md
Trott Dec 7, 2017
67c526f
doc: improve text for Console constructor
Trott Dec 7, 2017
23edd08
test: use Countdown in http test
idandagan1 Dec 6, 2017
f53b4df
doc: 'constructor' implies use of new keyword
CameronMoorehead Nov 28, 2017
bd4b97f
test: update test-http-should-keep-alive to use countdown
tomeromrix Dec 6, 2017
a50366f
test: improve assert messages in repl-reset-event
AdriVanHoudt Nov 6, 2017
ac6f345
build: allow running configure from any directory
gibfahn Nov 26, 2017
dcee5ed
doc: simplify and clarify FIPS text in BUILDING.md
Trott Dec 7, 2017
2d74af0
src: remove unused include node_crypto_clienthello
danbev Dec 8, 2017
3e70ee8
tools: simplify prefer-common-mustnotcall rule
cjihrig Dec 9, 2017
5383422
tools: simplify prefer-assert-methods rule
cjihrig Dec 9, 2017
ad0d878
tools: simplify buffer-constructor rule
cjihrig Dec 9, 2017
dbf5ddb
test: refactor test-child-process-pass-fd
Trott Dec 10, 2017
b1b9753
benchmark,path: remove unused variables
Oct 5, 2017
a528d57
test: remove hidden use of common.PORT in parallel tests
Trott Dec 5, 2017
d5fbd25
2018-01-02, Version 6.12.3 'Boron' (LTS)
MylesBorins Dec 20, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tools: simplify buffer-constructor rule
PR-URL: #17572
Reviewed-By: Anatoli Papirovski <[email protected]>
cjihrig authored and gibfahn committed Dec 20, 2017
commit ad0d878772f8533dbd4ed87b67b25a2ef3be346c
11 changes: 3 additions & 8 deletions tools/eslint-rules/buffer-constructor.js
Original file line number Diff line number Diff line change
@@ -10,16 +10,11 @@
const msg = 'Use of the Buffer() constructor has been deprecated. ' +
'Please use either Buffer.alloc(), Buffer.allocUnsafe(), ' +
'or Buffer.from()';

function test(context, node) {
if (node.callee.name === 'Buffer') {
context.report(node, msg);
}
}
const astSelector = 'NewExpression[callee.name="Buffer"],' +
'CallExpression[callee.name="Buffer"]';

module.exports = function(context) {
return {
'NewExpression': (node) => test(context, node),
'CallExpression': (node) => test(context, node)
[astSelector]: (node) => context.report(node, msg)
};
};