Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend shared library interface #19005

Closed
wants to merge 66 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
32932e4
Squash commit of all our previous commits
msoechting Feb 7, 2018
99b9de7
Fix errors introduced by merge
EmberFlare Feb 7, 2018
7f6a8d5
Further merge fixes
EmberFlare Feb 7, 2018
208db30
Update our init- and deinitialize methods with new master code
luminosuslight Feb 7, 2018
1ca52b3
replay central changes from refactor-start branch on new dev
justus-hildebrand Feb 12, 2018
c77d2a1
Added code from initial PR (#62)
Feb 12, 2018
e51dc56
replay changes from fix-repl branch on new dev
justus-hildebrand Feb 12, 2018
9bd425b
fix linter error
justus-hildebrand Feb 12, 2018
bae6b4d
fix small code smells
justus-hildebrand Feb 13, 2018
e2e25de
fix linter
justus-hildebrand Feb 13, 2018
b2a8f79
Merge pull request #67 from hpicgs/deinitialization
Feb 15, 2018
0abe5a4
Add if around eval script
luminosuslight Feb 15, 2018
d133ec8
Clean code
luminosuslight Feb 15, 2018
be93498
Fix documentation
luminosuslight Feb 15, 2018
aad189a
Merge pull request #69 from hpicgs/new-fix-repl
luminosuslight Feb 15, 2018
1959f89
Merge pull request #68 from hpicgs/new-refactor-start
luminosuslight Feb 15, 2018
40b20d8
Fix REPL spawning
cmfcmf Feb 19, 2018
cdce802
Add missing function declaration
cmfcmf Feb 19, 2018
e7f40c1
Fix typo
cmfcmf Feb 19, 2018
c52a994
Correctly deinitialize context
cmfcmf Feb 19, 2018
6d53a55
Fix style, remove debug output
cmfcmf Feb 19, 2018
efc78d6
Fix require not available in shared mode
luminosuslight Feb 21, 2018
ab7db6c
Merge pull request #77 from hpicgs/deini-fix
msoechting Feb 21, 2018
883795c
Merge pull request #78 from hpicgs/fix-allow-repl
msoechting Feb 21, 2018
b7621f0
Merge branch 'dev' into repl-fix
cmfcmf Feb 25, 2018
8fb4446
Merge branch 'master' into dev
cmfcmf Feb 25, 2018
a8dc3fa
Bring comment in bootstrap_node.js back
luminosuslight Feb 25, 2018
35ff063
Re-add error handling for initialize
cmfcmf Feb 26, 2018
984c3ea
Improved usage documentation (#72)
msoechting Feb 26, 2018
1e9c2f7
Remove deinitialize code
cmfcmf Feb 26, 2018
2d2227d
Remove some comments, adjust TODOs (#79)
cmfcmf Feb 26, 2018
6036ee2
Merge branch 'dev' into error-handling
cmfcmf Feb 26, 2018
737c015
Fix cs
cmfcmf Feb 26, 2018
873f871
Fix indent
cmfcmf Feb 26, 2018
b60ad85
Rename parameter to evaluate_stdin
cmfcmf Feb 26, 2018
8826721
Merge branch 'dev' into repl-fix
cmfcmf Feb 26, 2018
e751664
Merge pull request #80 from hpicgs/error-handling
cmfcmf Feb 26, 2018
2b67156
Whoopsidoopsi
cmfcmf Feb 26, 2018
a5f4250
removed travis.yaml in preparation for PR
Feb 26, 2018
695a8db
Merge branch 'dev' into repl-fix
cmfcmf Feb 26, 2018
ad630a5
fixed linter errors
Feb 26, 2018
3d0865e
Merge branch 'dev' into repl-fix
cmfcmf Feb 26, 2018
3aad7e8
Fix doc comment
cmfcmf Feb 26, 2018
9811298
Merge branch 'repl-fix' of github.com:hpicgs/node into repl-fix
cmfcmf Feb 26, 2018
385de54
Merge pull request #75 from hpicgs/repl-fix
Feb 26, 2018
f23feec
removed trailling whitespaces
Feb 26, 2018
9213545
Fix line length
luminosuslight Feb 26, 2018
e916467
Merge branch 'dev' into node-lib-interface
luminosuslight Feb 26, 2018
0f63853
POC of environments in all library methods
cmfcmf Mar 13, 2018
f9060d3
Add missing environment to Call()
cmfcmf Mar 13, 2018
81e9d6a
Remove Isolate::CreateParams, Isollate::Scope and Context::Scope as g…
cmfcmf Mar 13, 2018
c70d931
Remove _isolate variable (unsure about this)
cmfcmf Mar 13, 2018
3aeb883
Fix cs
cmfcmf Mar 13, 2018
c357218
Remove initializer_list methods
cmfcmf Mar 13, 2018
a686c96
Merge pull request #84 from hpicgs/remove-initializer-lists
luminosuslight Mar 13, 2018
646388a
Fix ignored return value of uv_setup_args
luminosuslight Mar 13, 2018
319f9ef
Merge pull request #86 from hpicgs/fix-argv-process-title
cmfcmf Mar 13, 2018
5e2fe3b
Remove outdated TODO
cmfcmf Mar 13, 2018
05e8b99
Merge remote-tracking branch 'origin/dev' into remove-globals
cmfcmf Mar 13, 2018
c2febfb
Merge pull request #83 from hpicgs/remove-globals
cmfcmf Mar 13, 2018
568191e
Add documentation and remove initializer_list call methods
luminosuslight Mar 13, 2018
d493e9a
Merge remote-tracking branch 'origin/dev' into add-environment
cmfcmf Mar 13, 2018
1fbcc75
Remove implementation of init_list methods, too, and fix namespace
luminosuslight Mar 13, 2018
f1196ca
Merge branch 'add-environment' of github.com:hpicgs/node into add-env…
cmfcmf Mar 13, 2018
9d6e944
Merge pull request #82 from hpicgs/add-environment
cmfcmf Mar 17, 2018
cfae579
Merge pull request #87 from hpicgs/dev
cmfcmf Mar 17, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix errors introduced by merge
EmberFlare committed Feb 7, 2018

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mdebarros Miguel de Barros
commit 99b9de7fe840742b949794b133ff32eba0cef3fc
9 changes: 4 additions & 5 deletions src/node.cc
Original file line number Diff line number Diff line change
@@ -4346,7 +4346,7 @@ inline static bool TickEventLoop(Environment* env,
return true;
}

v8_platform.DrainVMTasks();
v8_platform.DrainVMTasks(env->isolate());

if (uv_loop_alive(env->event_loop())) {
return true;
@@ -4689,7 +4689,7 @@ int _StopEnv() {
RunAtExit(_environment);
uv_key_delete(&thread_local_env);

v8_platform.DrainVMTasks();
v8_platform.DrainVMTasks(_environment->isolate());
WaitForInspectorDisconnect(_environment);

return exit_code;
@@ -4724,7 +4724,7 @@ void _DeinitV8() {
namespace initialize {

void _InitV8() {
v8_platform.Initialize(v8_thread_pool_size, uv_default_loop());
v8_platform.Initialize(v8_thread_pool_size);
// Enable tracing when argv has --trace-events-enabled.
if (trace_enabled) {
fprintf(stderr, "Warning: Trace event is an experimental feature "
@@ -4773,8 +4773,7 @@ void _CreateInitialEnvironment() {
// TODO(jh): Once we write a Deinit(), we need to put this on the heap
// to call the deconstructor.
static HandleScope handle_scope(_isolate);
isolate_data = new IsolateData(_isolate, uv_default_loop(),
allocator->zero_fill_field());
isolate_data = new IsolateData(_isolate, uv_default_loop(), nullptr);

//////////
// Start 3